From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751441AbdJCI7i (ORCPT ); Tue, 3 Oct 2017 04:59:38 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:55764 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751190AbdJCI7g (ORCPT ); Tue, 3 Oct 2017 04:59:36 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Date: Tue, 3 Oct 2017 09:58:48 +0100 From: Charles Keepax To: Chanwoo Choi CC: , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH] extcon: Split out extcon header file for consumer and provider device Message-ID: <20171003085848.tma5l5lq4yavddli@localhost.localdomain> References: <1506643305-4581-1-git-send-email-cw00.choi@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1506643305-4581-1-git-send-email-cw00.choi@samsung.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710030132 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 29, 2017 at 09:01:45AM +0900, Chanwoo Choi wrote: > The extcon has two type of extcon devices as following. > - 'extcon provider deivce' adds new extcon device and detect the > state/properties of external connector. Also, it notifies the > state/properties to the extcon consumer device. > - 'extcon consumer device' gets the change state/properties > from extcon provider device. > Prior to that, include/linux/extcon.h contains all exported API for > both provider and consumer device driver. To clarify the meaning of > header file and to remove the wrong use-case on consumer device, > this patch separates into extcon.h and extcon-provider.h. > > [Description for include/linux/{extcon.h|extcon-provider.h}] > - extcon.h includes the extcon API and data structure for extcon consumer > device driver. This header file contains the following APIs: > : Register/unregister the notifier to catch the change of extcon device > : Get the extcon device instance > : Get the extcon device name > : Get the state of each external connector > : Get the property value of each external connector > : Get the property capability of each external connector > > - extcon-provider.h includes the extcon API and data structure for extcon > provider device driver. This header file contains the following APIs: > : Include 'include/linux/extcon.h' > : Allocate the memory for extcon device instance > : Register/unregister extcon device > : Set the state of each external connector > : Set the property value of each external connector > : Set the property capability of each external connector > > Cc: Felipe Balbi > Cc: Kishon Vijay Abraham I > Cc: Greg Kroah-Hartman > Cc: Sebastian Reichel > Cc: Lee Jones > Signed-off-by: Chanwoo Choi > --- > drivers/extcon/extcon-arizona.c | 2 +- Acked-by: Charles Keepax Thanks, Charles