From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbdJCMKx (ORCPT ); Tue, 3 Oct 2017 08:10:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:40173 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750846AbdJCMKw (ORCPT ); Tue, 3 Oct 2017 08:10:52 -0400 Date: Tue, 3 Oct 2017 14:10:49 +0200 From: Jan Kara To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, jack@suse.cz, torvalds@linux-foundation.org Subject: Re: [PATCH 02/12] buffer: grow_dev_page() should use __GFP_NOFAIL for all cases Message-ID: <20171003121049.GJ11879@quack2.suse.cz> References: <1506543239-31470-1-git-send-email-axboe@kernel.dk> <1506543239-31470-3-git-send-email-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506543239-31470-3-git-send-email-axboe@kernel.dk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 27-09-17 14:13:49, Jens Axboe wrote: > We currently it it for find_or_create_page(), which means that it > cannot fail. Ensure we also pass in 'retry == true' to > alloc_page_buffers(), which also ensure that it cannot fail. > > After this, there are no failure cases in grow_dev_page() that > occur because of a failed memory allocation. > > Signed-off-by: Jens Axboe Makes sense. You can add: Reviewed-by: Jan Kara Honza > --- > fs/buffer.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index 1234ae343aef..3b60cd8456db 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -988,8 +988,6 @@ grow_dev_page(struct block_device *bdev, sector_t block, > gfp_mask |= __GFP_NOFAIL; > > page = find_or_create_page(inode->i_mapping, index, gfp_mask); > - if (!page) > - return ret; > > BUG_ON(!PageLocked(page)); > > @@ -1008,9 +1006,7 @@ grow_dev_page(struct block_device *bdev, sector_t block, > /* > * Allocate some buffers for this page > */ > - bh = alloc_page_buffers(page, size, false); > - if (!bh) > - goto failed; > + bh = alloc_page_buffers(page, size, true); > > /* > * Link the page to the buffers and initialise them. Take the > -- > 2.7.4 > -- Jan Kara SUSE Labs, CR