From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752827AbdJCNNq (ORCPT ); Tue, 3 Oct 2017 09:13:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:41310 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751943AbdJCMWQ (ORCPT ); Tue, 3 Oct 2017 08:22:16 -0400 Date: Tue, 3 Oct 2017 14:22:12 +0200 From: Jan Kara To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, jack@suse.cz, torvalds@linux-foundation.org Subject: Re: [PATCH 03/12] buffer: eliminate the need to call free_more_memory() in __getblk_slow() Message-ID: <20171003122212.GK11879@quack2.suse.cz> References: <1506543239-31470-1-git-send-email-axboe@kernel.dk> <1506543239-31470-4-git-send-email-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506543239-31470-4-git-send-email-axboe@kernel.dk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 27-09-17 14:13:50, Jens Axboe wrote: > Since the previous commit removed any case where grow_buffers() > would return failure due to memory allocations, we can safely > remove the case where we have to call free_more_memory() in > this function. > > Since this is also the last user of free_more_memory(), kill > it off completely. > > Signed-off-by: Jens Axboe Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/buffer.c | 23 ----------------------- > 1 file changed, 23 deletions(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index 3b60cd8456db..bff571dc7bc3 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -253,27 +253,6 @@ __find_get_block_slow(struct block_device *bdev, sector_t block) > } > > /* > - * Kick the writeback threads then try to free up some ZONE_NORMAL memory. > - */ > -static void free_more_memory(void) > -{ > - struct zoneref *z; > - int nid; > - > - wakeup_flusher_threads(1024, WB_REASON_FREE_MORE_MEM); > - yield(); > - > - for_each_online_node(nid) { > - > - z = first_zones_zonelist(node_zonelist(nid, GFP_NOFS), > - gfp_zone(GFP_NOFS), NULL); > - if (z->zone) > - try_to_free_pages(node_zonelist(nid, GFP_NOFS), 0, > - GFP_NOFS, NULL); > - } > -} > - > -/* > * I/O completion handler for block_read_full_page() - pages > * which come unlocked at the end of I/O. > */ > @@ -1086,8 +1065,6 @@ __getblk_slow(struct block_device *bdev, sector_t block, > ret = grow_buffers(bdev, block, size, gfp); > if (ret < 0) > return NULL; > - if (ret == 0) > - free_more_memory(); > } > } > > -- > 2.7.4 > -- Jan Kara SUSE Labs, CR