From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750879AbdJCMnL (ORCPT ); Tue, 3 Oct 2017 08:43:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:43814 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752436AbdJCMnI (ORCPT ); Tue, 3 Oct 2017 08:43:08 -0400 Date: Tue, 3 Oct 2017 14:43:05 +0200 From: Jan Kara To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, jack@suse.cz, torvalds@linux-foundation.org Subject: Re: [PATCH 05/12] writeback: switch wakeup_flusher_threads() to cyclic writeback Message-ID: <20171003124305.GM11879@quack2.suse.cz> References: <1506543239-31470-1-git-send-email-axboe@kernel.dk> <1506543239-31470-6-git-send-email-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506543239-31470-6-git-send-email-axboe@kernel.dk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 27-09-17 14:13:52, Jens Axboe wrote: > We're writing back the full range of dirty pages on the devices, > there's no point in making this special and not do normal range > cyclic writeback. > > Signed-off-by: Jens Axboe OK, since this is just ordinary "memory cleaning" writeback, I agree that range_cyclic probably makes more sense. You can add: Reviewed-by: Jan Kara Honza > --- > fs/fs-writeback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index bb6148dc6d24..65e6992d8719 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -1971,7 +1971,7 @@ void wakeup_flusher_threads(enum wb_reason reason) > > list_for_each_entry_rcu(wb, &bdi->wb_list, bdi_node) > wb_start_writeback(wb, wb_split_bdi_pages(wb, nr_pages), > - false, reason); > + true, reason); > } > rcu_read_unlock(); > } > -- > 2.7.4 > -- Jan Kara SUSE Labs, CR