From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753899AbdJCMvC (ORCPT ); Tue, 3 Oct 2017 08:51:02 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:57966 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753418AbdJCMu5 (ORCPT ); Tue, 3 Oct 2017 08:50:57 -0400 Date: Tue, 3 Oct 2017 13:50:27 +0100 From: Roman Gushchin To: Michal Hocko CC: , Vladimir Davydov , Johannes Weiner , Tetsuo Handa , David Rientjes , Andrew Morton , Tejun Heo , , , , Subject: Re: [v9 2/5] mm: implement mem_cgroup_scan_tasks() for the root memory cgroup Message-ID: <20171003125027.GB28904@castle.DHCP.thefacebook.com> References: <20170927130936.8601-1-guro@fb.com> <20170927130936.8601-3-guro@fb.com> <20171003104939.vm7pezgef7bqxe2v@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171003104939.vm7pezgef7bqxe2v@dhcp22.suse.cz> User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [2620:10d:c092:200::1:8d4] X-ClientProxiedBy: VI1PR0401CA0017.eurprd04.prod.outlook.com (2603:10a6:800:4a::27) To SN2PR15MB1085.namprd15.prod.outlook.com (2603:10b6:804:22::7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 25abcfb1-c46f-458d-f772-08d50a5d5a8b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:SN2PR15MB1085; X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1085;3:KHM3zczLDtOpXId81h743s0ZbXarSGjSXCSuhz83AePoppupmDu/uGqVk/ffioXVJKOW0TTzg4MzQVqniQmySVDNRW9Gat6S74hkotLd8zAzS/6Ku9xbFRwfzh3slJc/tAknAOoPovZ7BED8AzCiLKgFiAd+QFHlrjtg1gsAimXTroDDJxcxc+y5KJsVKNO5pk5F8zivGfRkmWAieAfQnziZfoTIt//aEmnkDmQk4rrBGzfGd+1dgTtiSLw01mox;25:kqpP9LdVl8zdeEZ17lXG7ZDI6fhl0yuI/bWYX6NhJFEXRZ6KDvdkINZQVy290zYw9PfdMxq1xTDkXMbF/O2Tr5Z2CxwSam6xKDDWbN2jGCtAXPvXCso0RWlehqIJSa/5gAdfpHE6Cxkrd0c/r0Vb5iZgmK2v7WBntPAtlZesEWOUxlc5cbiIcnjIUwySQNZ4aJ10DfGvKObLEFfnSp5pwm2G93zQ4OFtlTYWkV+xCM3f0C4XH4oSWljx+VMjKoeXYzHTASRIFXxhcqUSJkqyWeIhJFMBQowowQou/RzqUDuVWetrd3mmCKJFAVgm+jPLLbbhdnAoDIAam0UnXdNWQA==;31:QkLrXY++z43o5Nl0OoYUiDuv2DpIxz9wdcf1KhNNwca+ePJC3taaNoJIhLwEJfh2kkgDVumy/E046w2ujcSloeCaJ206JjerFwRIJaB2zWxm96h7qtLxNbej0Of8aX7qXcn/mpdwuNG1iUCXjX5mhjnsBHmO8bcFtVBoYWWMR6uzRUbM+bQHK/KQS9BUBk3mWG87P2gCE1BZoVM/dXVQ5Mlpj30gapSyQoJdS8sKYzw= X-MS-TrafficTypeDiagnostic: SN2PR15MB1085: X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1085;20:JLzRp6rSdXa144Qu4rRpyM7vB3BNP3Q0rOz1EgG3FlxMCQxA4Oz4Y3C4hZTmflzVsQr6MAGtu2/384JCjBAc3B3x1fGaKJdxmQCiG9o8YBGaRaLz2bnspWeJTFhPv3y3QQbvxQyp63kC0jeX6XA8oPp0JYOXnSnMz5u0UPmLfxgDATi00+TM4+LIIt+p/nqD9adEjg3/LihY53j1r6JiLli3S0ns0+/IrAu1Y7/LszhFO68wTU4ySpQOVkF3uch3TNLt/BiieEDd7kPqMIIqD4q+BTzdDlJ1gqMR0YqxOyu4yeI+LUkg2IAeuI7gafkaBWJ7bQZb58YcQL+TCLNz4PtO7TO9zE/4YnO6/vdJu+qbD17uqK++PsUrDD0NNUGQ6ms6k2tnaZlLhbBdqwhU92iOk0+HalyQMQGV9uGpDTdCw8hKOZpZVlzRrLa9+UChaNmPGGzavhjlryxyCDorzHiTKkwTWouq7g6nMgW5cxknzkORLMzkrtkr6n+rV2vb;4:4HEC91iw5/JMOVIynk3l1tQwjBBfyCot+eYwL8s+D6h3Tmm/4AfgJsIfMFwEQeePsMYufgKaE/eag2/IgIg9oyEEagT2eJWABUn6IJPjnKjZGkOWFgYgJhTahB9gKx4/QlmFFJGe3SlbulkcHwoxDiqz8DlqVCRHKUP09YseWunf+EGLrtcQgU/lztxkyAzBYgS8zz9LzaPqAEv2nXLZJaryfLhjhdnAaLra4TXX6xruTcLBy90tmPvGithvVs17cL71pE2tjsqzPROaVmvxcSc3NCMG5CnvbZ6pXIxYQDK9Qc1heJuverFLvXxVOWmmwTgdXYMM1i04pnFEG4vaPekmdeuHWlJ5OJQJEYtoSDC4fUgqjsxamxV5Q5WDivWM+XUt2rxFjjf4PS3vG8hteg== X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(67672495146484)(211936372134217)(153496737603132); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(920507026)(6041248)(20161123564025)(20161123558100)(20161123555025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN2PR15MB1085;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN2PR15MB1085; X-Forefront-PRVS: 044968D9E1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(189002)(199003)(377424004)(24454002)(50466002)(105586002)(23726003)(106356001)(8936002)(2906002)(34040400001)(25786009)(86362001)(101416001)(189998001)(50986999)(76176999)(54356999)(229853002)(7416002)(6116002)(1076002)(8676002)(6666003)(81166006)(81156014)(6506006)(47776003)(33656002)(4326008)(16586007)(97736004)(55016002)(7736002)(58126008)(2950100002)(6916009)(53936002)(316002)(9686003)(83506001)(54906003)(305945005)(68736007)(6246003)(39060400002)(5660300001)(478600001)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:SN2PR15MB1085;H:castle.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR15MB1085;23:PEQwjUw0Bzt4S92bB1mpdtlMvnO2nIDIDHc2aDFOD?= =?us-ascii?Q?t2hLCAKTlemJLmJFaT6UWnZTb5IiHbdIv6jjT5nCdJtgZ2Z2EIJLkHbLAmeg?= =?us-ascii?Q?JCgH0xboM87q1ZbkH63iISO++A6OrfEk5h+pC/TkumRq/095h9O9Bw3CQ4/X?= =?us-ascii?Q?jEhJ9ddMkkWqzHqHrOYPzCQePudEBMX7o4tB4MpWo++3jSvV5DXW4s5MNoG1?= =?us-ascii?Q?2zGAALI92yobtr76vE11RVaA6o7V0wmbkxIqRncmRbMF/OCmJQh7oX9xf9IC?= =?us-ascii?Q?SOBsThf3ONpSPGzQRAxk++m7PKVv/bCS5z0A0iPQoIhscgFMlQnf/uP5uutd?= =?us-ascii?Q?93WJtTkvT5Lp50ZnoRJJykFh3dEqb65Ck8pbljIk6WLyfe7oo6IW2Re34QQs?= =?us-ascii?Q?azIhMfqS/3inRXo4M30FYgU9ZSDl7ekLkiEvvS1sDCkLa2Ht+oY5jyObZSDI?= =?us-ascii?Q?LIqml3X0ZQshLcy+ewVSpKolMNiNwaMZIPbv/ET/8SmJvVjtPzqzj3R03Aa6?= =?us-ascii?Q?LEFihan9Apj/tjjLqEgrvw1j42vig/k3c8iNJH0YLCwKvTY/qt7XLpn//BH3?= =?us-ascii?Q?TK4pnmsO1lS1XF5GC9w4iwDN/y/0nxXWUkmtIydCWVFUk1J5BEvAoEBe3fhd?= =?us-ascii?Q?Qj+g9lUemXD3srR+DYi9pMNGD0tUX0n5mWpUnCJMbjBRH0G/NkCjduBajjs1?= =?us-ascii?Q?nkmZigDZ7hSuziTpOzPZ2ZNGpJuVVIVq4UK0oZVYkygCKJKdR3Aw8Kz8MKmy?= =?us-ascii?Q?pwUUguzydk+Hg27vVtPuvhSq2ik0NiqrVkYqPHz+2mTvkfHY/OB+BZVvTDQd?= =?us-ascii?Q?m6Q004UTLW6eq90IW83cca08pXDJMPuk/4mED4++SrdPAP2r5z5KUzcIWBnR?= =?us-ascii?Q?AZ9Kn1FWYYtCR+TK6F0H1rd3CYNrtBUqA7qp0RX2wbzpW6kiFh9OhIP+kcof?= =?us-ascii?Q?y0EZTnaaEBx5LD5wTUna9dOKB4ioEiZ6TcxjtrKjcOoluQJ5qe/kFwkKlykB?= =?us-ascii?Q?AVYzJZHdfqYsTwHEPTu/MWOl7INFpj4/uHGgVm3cYeahZIJhAu025bNpkFtT?= =?us-ascii?Q?DXM7LqfLCy4xd/HTkPPv/xjNdxT8Iz3prrRBEeSJ/4IVdjHVsJRvNTvm4Aly?= =?us-ascii?Q?2cgd9dxdmVKeOMhP927wX2iAMKp4jq6NMdY7tWcJvBzaP99HLgjEv6F00L7V?= =?us-ascii?Q?aFHgdB55IOJgxRlBoQm0eht9GWrReqgqTVt5Jox3Oto6trC7r6myTeR2ywxw?= =?us-ascii?Q?mEbvuPo/OPjvV4mhx8=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1085;6:vtoRXkl7Txnk/LPZZWwKg31c9eeWK8ClOxh9rk62e80avBdfVQjz0sntPrEpXpWIIV5Fl1ylhQ4u8vdCANbi72nmNl2AOTlAxJPrI+Nr9VKVFz0UkFhwB99fexz/OzmWuZEEBFdn14rp6EYm6ijyFb0LMLHbqDZcH8E8iOghU6w22vBfsuFc7DTm2VQYiFsidvQPxA8MGBlEvPSJCSITDuPoaG4cE7lmpgHvqBA/8th0eG6e1cfppUI2seWL1gEyAm+mWZzMwzqCfQFHM3HhMu35nsGbuHh/EfShvVU/qQcH6VTR255tppNhEFDjANDBxDfZ4dlAwRUxzm0on48/ZA==;5:6+Pkyjrd1b1Om1xbVrXZDOZtLIuyv2L3PGu9JQypN8Y/GJZnVMGeBJth6tDrMOt5eDAU48Ts02G6S6TaC043pBdremKawBaZKjufTGzh3TAXWga+5s/FB/iwA32Wgy2zK6LLXSmJjDMVLB7aYDw2Mg==;24:Ab9nwlaARJK4bp6SNj560VfIKUnwv93v/TRHmkJbkJde2WgfYVtpS7sgZ0tdyx8Uc/fWoM5M48cHa4D/OX6lsM7rmN+QmnRjm72HgaO3ob4=;7:3hKItEBU6xFg629uY8OrecVPrTmbaXHecFfNXMtVx37dfcyuavF9KNJ2BK7XdK9JLY8q2eb2BW5IlH26QOl8y6QI3nyEfwJoCy3tzwN+s+QpjDYlIbfWa+b7PO+NalNG946XQbSnqCy4FQ/2lNzaRNghZNfmQw65XAIMvLJlVNQO4hJ0l/DiGwwIrLnSg+6cx5vtC0QtcEactkegLoQ+KaD1q54gkP+PQKzANeCCrck= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1085;20:O15Qv6czTDAax02jpuvA7BzvWg2dQiWjxUYPzGSmGbE/p6mQwpsyJUeKuR7KaOiZOikeUrKFkko127sRt2mGcI3p6X3pnvy0VSinu0LWzaG8LIEBtLuxIJMo8mcN+wEuwVptVN8oRyrFjcz/2Ok9PPdvNod/KHJKh4AgL2e8Wvo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2017 12:50:38.7025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR15MB1085 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-03_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 03, 2017 at 12:49:39PM +0200, Michal Hocko wrote: > On Wed 27-09-17 14:09:33, Roman Gushchin wrote: > > Implement mem_cgroup_scan_tasks() functionality for the root > > memory cgroup to use this function for looking for a OOM victim > > task in the root memory cgroup by the cgroup-ware OOM killer. > > > > The root memory cgroup should be treated as a leaf cgroup, > > so only tasks which are directly belonging to the root cgroup > > should be iterated over. > > I would only add that this patch doesn't introduce any functionally > visible change because we never trigger oom killer with the root memcg > as the root of the hierarchy. So this is just a preparatory work for > later changes. Sure, thanks! > > > Signed-off-by: Roman Gushchin > > Cc: Michal Hocko > > Cc: Vladimir Davydov > > Cc: Johannes Weiner > > Cc: Tetsuo Handa > > Cc: David Rientjes > > Cc: Andrew Morton > > Cc: Tejun Heo > > Cc: kernel-team@fb.com > > Cc: cgroups@vger.kernel.org > > Cc: linux-doc@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-mm@kvack.org > > Acked-by: Michal Hocko