From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbdJCO0J (ORCPT ); Tue, 3 Oct 2017 10:26:09 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36455 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdJCO0I (ORCPT ); Tue, 3 Oct 2017 10:26:08 -0400 X-ME-Sender: X-Sasl-enc: ABJAvGp3I+El1/nDTCWjz9FfjFfRlGiq5JmOvRsZZknn 1507040767 From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: "Kirill A . Shutemov" , Abdul Haleem , Anshuman Khandual , Zi Yan , Andrew Morton , linuxppc-dev@lists.ozlabs.org Subject: [PATCH] mm: remove unnecessary WARN_ONCE in page_vma_mapped_walk(). Date: Tue, 3 Oct 2017 10:26:06 -0400 Message-Id: <20171003142606.12324-1-zi.yan@sent.com> X-Mailer: git-send-email 2.14.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zi Yan A non present pmd entry can appear after pmd_lock is taken in page_vma_mapped_walk(), even if THP migration is not enabled. The WARN_ONCE is unnecessary. Fixes: 616b8371539a ("mm: thp: enable thp migration in generic path") Reported-and-tested-by: Abdul Haleem Signed-off-by: Zi Yan Cc: "Kirill A. Shutemov" Cc: Anshuman Khandual Cc: Andrew Morton --- mm/page_vma_mapped.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c index 6a03946469a9..eb462e7db0a9 100644 --- a/mm/page_vma_mapped.c +++ b/mm/page_vma_mapped.c @@ -167,8 +167,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw) return not_found(pvmw); return true; } - } else - WARN_ONCE(1, "Non present huge pmd without pmd migration enabled!"); + } return not_found(pvmw); } else { /* THP pmd was split under us: handle on pte level */ -- 2.14.1