From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752095AbdJCOfV (ORCPT ); Tue, 3 Oct 2017 10:35:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32868 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbdJCOfU (ORCPT ); Tue, 3 Oct 2017 10:35:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4CFA72576D Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Tue, 3 Oct 2017 09:35:18 -0500 From: Josh Poimboeuf To: Tetsuo Handa Cc: bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org Subject: Re: [4.14-rc1 x86] WARNING: kernel stack regs at f60bbb12 inswapper:1 has bad 'bp' value 0ba00000 Message-ID: <20171003143518.xgw7ifylwjhi25xx@treble> References: <201709142006.GJE87018.QSFJMHOVLOFtOF@I-love.SAKURA.ne.jp> <201709221335.EDE64522.JSHFFMLFOVOOtQ@I-love.SAKURA.ne.jp> <201710031929.GGI78159.FHLQOJOtFMVSOF@I-love.SAKURA.ne.jp> <20171003103744.hxnz7o73rxzj63gx@pd.tnic> <20171003132915.poy7sv73eev6to7m@treble> <201710032244.ADC26527.FStOFOJOFLMVHQ@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201710032244.ADC26527.FStOFOJOFLMVHQ@I-love.SAKURA.ne.jp> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 03 Oct 2017 14:35:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 03, 2017 at 10:44:13PM +0900, Tetsuo Handa wrote: > Josh Poimboeuf wrote: > > > On Tue, Oct 03, 2017 at 12:37:44PM +0200, Borislav Petkov wrote: > > > On Tue, Oct 03, 2017 at 07:29:36PM +0900, Tetsuo Handa wrote: > > > > Tetsuo Handa wrote: > > > > > Tetsuo Handa wrote: > > > > > > Tetsuo Handa wrote: > > > > > > > I'm seeing below error between > > > > > > > 4898b99c261efe32 ("Merge tag 'acpi-4.13-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm") (git bisect good (presumably)) > > > > > > > e6f3faa734a00c60 ("locking/lockdep: Fix workqueue crossrelease annotation") (git bisect bad) on linux.git . > > > > > > > > > > > > F.Y.I. This error remains as of 46c1e79fee417f15 ("Merge branch 'perf-urgent-for-linus' of > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip") on linux.git . > > > > > > > > > > > > > > > > This error still remains as of 6e80ecdddf4ea6f3 ("Merge branch 'libnvdimm-fixes' > > > > > of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm") on linux.git . > > > > > > > > > > I'm suspecting that this error is causing very unstable x86_32 kernel. > > > > > It seems that this error occurs (though rare frequency) even on x86_64 kernel. > > > > > > > > > > Nobody cares? > > > > > > > > > 4.14-rc3 still trivially panics due to this error. Is this problem known? > > > > Can you try with the following patch? It should hopefully give more > > useful information in the dump. > > > I see. Here is the result. Hm, that's not what I expected to happen... I suspect this is stack corruption, with the result being slightly different every time. Can you see if this patch fixes the panic? diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index 44c8d0d17170..b4a5e60488aa 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking/lockdep.c @@ -1986,7 +1986,7 @@ check_prevs_add(struct task_struct *curr, struct held_lock *next) { int depth = curr->lockdep_depth; struct held_lock *hlock; - struct stack_trace trace; + static struct stack_trace trace; int (*save)(struct stack_trace *trace) = save_trace; /*