From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752261AbdJCPHV (ORCPT ); Tue, 3 Oct 2017 11:07:21 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:43310 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbdJCPHR (ORCPT ); Tue, 3 Oct 2017 11:07:17 -0400 Date: Tue, 3 Oct 2017 17:07:09 +0200 From: Peter Zijlstra To: Will Deacon Cc: linux-kernel@vger.kernel.org, john.johansen@canonical.com, paulmck@linux.vnet.ibm.com Subject: Re: [PATCH 1/2] security/apparmor: Replace homebrew use of write_can_lock with lockdep Message-ID: <20171003150709.53fz7daydyomfuly@hirez.programming.kicks-ass.net> References: <1507041166-10618-1-git-send-email-will.deacon@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507041166-10618-1-git-send-email-will.deacon@arm.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 03, 2017 at 03:32:45PM +0100, Will Deacon wrote: > The lockdep subsystem provides a robust way to assert that a lock is > held, so use that instead of write_can_lock, which can give incorrect > results for qrwlocks. > > Cc: John Johansen > Cc: Peter Zijlstra > Signed-off-by: Will Deacon Thanks Will, good to be able to finally remove that API.