From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752280AbdJCPX2 (ORCPT ); Tue, 3 Oct 2017 11:23:28 -0400 Received: from mail-he1eur01on0125.outbound.protection.outlook.com ([104.47.0.125]:11168 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752002AbdJCPX0 (ORCPT ); Tue, 3 Oct 2017 11:23:26 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; From: Andrey Ryabinin To: Andrew Morton Cc: Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Ryabinin Subject: [PATCH] mm: remove unused pgdat->inactive_ratio Date: Tue, 3 Oct 2017 18:26:11 +0300 Message-Id: <20171003152611.27483-1-aryabinin@virtuozzo.com> X-Mailer: git-send-email 2.13.6 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: AM5PR0701CA0016.eurprd07.prod.outlook.com (2603:10a6:203:51::26) To DB6PR08MB2822.eurprd08.prod.outlook.com (2603:10a6:6:1d::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18ad13b4-ac6e-4e43-bb93-08d50a72af29 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DB6PR08MB2822; X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2822;3:8gtwJoNdaJk54iPlZZCR0O0GTgJHeC/fDQmOZyOuiHOoXspAY6b+2OIRT1aTZqmXv9UmJRXUAqx0B9fvYIqyyJXvbOaPstVEmrYnTHbTkDip3qVlCugHpwDQlqaye4H2+QpjGlPUwhZt3KfGAy4A3dJW8NwtCnXHwhRBQMWKuSF5EWjg6V8CjKYtF+bqEtdyLTo1ARrccbhc5tleI4VHAky1KulwHr7tku7eyHUuRntYklDfkMBY6WXxk481XNTj;25:QfVBb70dg7PGTx51IFHAj9eSgk4dvUUMZXolUdkAd8KLrjiL5oYL3TnWq2Fp0dOuVnDb2SEoC8g9rlgnxmHK78usK0vqtZZTj7lB5BcTebjkRkvNLYAps45FrcVl0LeSlc2VieMCi6y/ibKIXwfhkSv2zpe4d+7ODHhkFt340ytQ2rvHJf/mMMvC46Us6UzN+ddjw5DaIQbBbCxAvnj/OTrNPtqBH6ogcw12KCwZfXpTVdzOfbMRTIJshmBTWy809WgCtmzhhlnfxRaDI/v7oQq+Ew3HEcf6Ihd21UClCCS/K2glHQWo9TTUdVTp2z6ybtTtb9/7FK8TRLZTjomBDA==;31:Vo9IW6D2ZUIUfwxNOY52wBotdJXgUx7uh3uXhm9fTiM28j6TnIOOrHsqvaRBQIN9aWZA8sqGCk99efCt0J4t3r34+APgHI+3d6VFC6gekeRQaUXIA+T8KqqCyTL6F3VmagzIlb2okohcdEiUbLqFTE3aJQGC0XkbE6HRovLcMSONcYUWuN2Kpwuhc0niurEGU1RESaJwARwob8eGwUVCbPPE9xZnmjd6n13zE/Ojefs= X-MS-TrafficTypeDiagnostic: DB6PR08MB2822: X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2822;20:05Wj6SxAj9xpbLZlm7LdP4GXuvisFo7IRRzk7CzCSnKkIrhjJg/aGs2vseuAXeEmG09yv0TNnZpYvYt34C6i2XbyvY9oGeXOog3G1tL8xFZx+Q+SbYq94UxXPsq7YKCk+YX1B/fKmuOTV9g1eAnyrWhbw6dDn72osqto0S0NbTW6WwCLWAaawzsurH9yLFURAruQa/+8+knPrHyxbLTPOtQng3P9AiMcjTBijsN3zno4iEIaCu1QawtAIMR7Ly/VKLiCIs5Pxz9g4f2+3O5vpQaUh2uzqb+pggwCEG3nTPPAySdBMWvWoE1l3NVS2BeFG1KAhCyHj6CyzA81v8HRXsLLCbCBgVO332H6W7Ej0ud41Yk0zb1RmnsZO0g6SHoAaBOKjYwCPsgoAEeGPLAiYEWiV2tpdiWgpGVCNyJnkC8=;4:rWeZW8ntjp5iIFkMHJgEaDVCAOXVWSyzaupN1uhdED2Wfdfakiw3S7j7/0CQCD3atgMTPjOvKoSMhBGgja4aJhDq7i+OErcAeJadR1m5PWI91LOzpzY3ruxarySDonXgFGcJN+4yA6cEIcIBLmamwFaDxrHGe9YMpJ7yU0q3t9ubXVtM3n9Nuf7ghGXaC4dQeP+giVI9jrJoh94bKEgk8yyPtg8IyICwdApBi/YSi4U69Pm2lun3Fo/aSC/kJO1s X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6041248)(20161123560025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB6PR08MB2822;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB6PR08MB2822; X-Forefront-PRVS: 044968D9E1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(6069001)(346002)(376002)(189002)(199003)(6486002)(33646002)(6506006)(2906002)(5660300001)(7736002)(54906003)(97736004)(81156014)(6666003)(81166006)(6116002)(305945005)(16586007)(76506005)(8936002)(53416004)(6916009)(1076002)(316002)(36756003)(3846002)(5003940100001)(25786009)(50986999)(68736007)(8676002)(106356001)(50466002)(575784001)(86362001)(48376002)(69596002)(53936002)(105586002)(4326008)(47776003)(66066001)(16526017)(101416001)(50226002)(189998001)(6512007)(107886003)(478600001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR08MB2822;H:localhost.sw.ru;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB6PR08MB2822;23:L246YGYsql+4pLowhoZPVJhqtj3GXxory8Uoe96hB?= =?us-ascii?Q?XcCN/pP1oGPXMZjrwBP5cqENoaVFNyJRj0nhIDvuSkiIIVZBOd3IO19z7Ly7?= =?us-ascii?Q?Y0bLFf253a9/G2nA6excl1XakjpV9oPJpq0u/pkXd3ErdtHOCF/hY3/vftCT?= =?us-ascii?Q?SAJpQxlVqgrz25OHy3INBO1jqzATm147VsK2RbOZpEmEu9yGyrupkmN4d0Yz?= =?us-ascii?Q?3AjP7UU2SY7njkm1YrcM616AIF0gkEsG+ybV58R86h1NmZ9107zhMfCCqdHQ?= =?us-ascii?Q?Uu6ngITKKN5zHokkov+1rE7NvuyJJcF44lWwcHy02YSkBK691YWwQLbNN19Z?= =?us-ascii?Q?DS5NhPxurFs4E/QHfEOv2CMS0yezVZrbcsIjafH6nEUQzeYzL2gyOEKV0bls?= =?us-ascii?Q?o7fz6sDGmRv3OSLT8nNnMjP3rY1fhY1stBFsHjTiOzh2pKQuNaDYD7kNsdxH?= =?us-ascii?Q?G+pMZ21gMtmG6R1HXOC5RsufYpPQeK1EdK+goaartuH884hRXSHcqmVoZZ7B?= =?us-ascii?Q?u6YyjmZeKNLV8zxTkt1ws/AHbCyvQKFBufftXpHBpgtCZoyDTnjXLMiSdcCz?= =?us-ascii?Q?4PvOzKz6v1hfCHMpk9a06E6GlNNl8mlJ7onM0Z6dj9ajZe1F2btJ2uFYDGwu?= =?us-ascii?Q?1lr+6KayxQQAfQfUXsXGGXpeyZ7bqDSRaH8khV4NsZQovXcNttNIEf9WIDLQ?= =?us-ascii?Q?Bn3d5y0Kq+4H1v4GOTQII0SKL3h7hFPMMdVbnIS7pAB4PMzJDhPx3DyxiD8T?= =?us-ascii?Q?yp4SSBLlhCvcj/YzES3K6ffHRBPxxMz+knl9C3ZaLGcEiC3uQTOgQnEqwkcB?= =?us-ascii?Q?h/3nvuuWmm/RnF8PxxuyssIFXWozoFEaHawXEPbjvcs1wJ7fvYu3rUCrWliS?= =?us-ascii?Q?PaypgeQVdub+J2wzK0cUpRBzYn3/W86UIWqCK25q6Wi/o/RhBNc6o+qjQ8id?= =?us-ascii?Q?/jQFaYiezY/idDM1Pftd/bNssUnuzhVWi9MgUjoaP6Vp6zxu9MLg6+Giz4rM?= =?us-ascii?Q?UWzGS+CUnmaIcSiUQbwPyCA4O6n1yiSin1MWA3ZG0GGL6cAiqJydvztWc2CK?= =?us-ascii?Q?LUhkzxMoyAiEqiWEoKRMLhePYl01T72ERXxTRwlr4r/Pw7hNZP48YJ/uFbBI?= =?us-ascii?Q?G+ErVIXx+BbX52IvD//ZBagiPvG0Q5AHHUtRazNzqeE23hACgFqJv4E6un8y?= =?us-ascii?Q?mQjL7BqFnRXuAI=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2822;6:NCoY6AV/Jw9lmYa5f7rpagHrVZabIhpUhWKVuXk7aPyOvyLvTLYmZ7En9M4EBecObYd8cZbiron9IzlzPWbo3BK/gEU/rKVBHZsLIdbLsaxB7NfvF7UCBGMGFt+Z7YImunrlADEVdPqKf3se7JgCyadn5nuJQyaTID/il8h8pVo1MIul6rfWXoGjoL67RvoEEq4+sH8KrO6gcT4RrBUNkCE2hi6vg9mu3V//3CPconc4hsV19syPXnPsl+NqrLdsXwjcVOG7aA8kiCYqScu4MNmGWkoAIjwA4c6Ul57v3VLjXBjc2FbO4DsB+HldWPdq3zSv92clxc2waob2ikFImA==;5:Qc8kpM/qYlmCR3ZXbI+X6uF64Lv6FDnTzKLucTTeLGQ2J/ANfC3QtupYDgleeuSDmfPZ6kgm3ZZh13B0HZfJRPx97p5AovYzWvuItWnWpEVK5O0f0vQ58WK4zL4+WcLnqVoUYZ55ipOMA9BYwVdcbQ==;24:xtCjL7UURPFk3OJf1iBP63RMeND2ckXo/ZeMFZBT7QfTUH7vWJCyTo60UFmw8NnMgJRcnE0N5i9Y/8w+DptFLCYC9laCK2Fxy/F9B3sLqCc=;7:sZgt7YX3EUDbHfj+8XLwt+ZJiV0s29P5XtyszesS9gwx/rkh+tN8UXQu1kChGWRYe6rybXAwML7iny6Gkw+e6gbWgE5sG8+ak2375PhEtbFJ07SO9vUVOrCF6RILbXF5hjxzOudk+ad108Yl1shRllDKBAPvMG7MLZEkK24zeOakgk5hu0Jrqq5ZWqffheUlvxNiZojUREeL0Sdc4VK3JUVhGfDuTv56BSSjf7iLemo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2822;20:ay1mzH7GNVdOeFRZSo2joHxB1R/UexKbbahOog243i50S0+9UkxrmUFIfEsKzSYOZu1ADCl7qqjEdhQ7fNz+wxf5EX1+nK8RqyBepwqnN7ZGTwg7iNNxLhLYPKbuU3sCl3aw9eoKyOeCXbfnYCPTJeLpvksbenPXx7L3n3nIBGY= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2017 15:23:21.9403 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2822 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit 59dc76b0d4df ("mm: vmscan: reduce size of inactive file list") 'pgdat->inactive_ratio' is not used, except for printing "node_inactive_ratio: 0" in /proc/zoneinfo output. Remove it. Signed-off-by: Andrey Ryabinin --- include/linux/mmzone.h | 6 ------ mm/vmscan.c | 2 +- mm/vmstat.c | 6 ++---- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index c8f89417740b..a6f361931d52 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -711,12 +711,6 @@ typedef struct pglist_data { /* Fields commonly accessed by the page reclaim scanner */ struct lruvec lruvec; - /* - * The target ratio of ACTIVE_ANON to INACTIVE_ANON pages on - * this node's LRU. Maintained by the pageout code. - */ - unsigned int inactive_ratio; - unsigned long flags; ZONE_PADDING(_pad2_) diff --git a/mm/vmscan.c b/mm/vmscan.c index d811c81ddb69..245b3d482791 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2081,7 +2081,7 @@ static void shrink_active_list(unsigned long nr_to_scan, * If that fails and refaulting is observed, the inactive list grows. * * The inactive_ratio is the target ratio of ACTIVE to INACTIVE pages - * on this LRU, maintained by the pageout code. A zone->inactive_ratio + * on this LRU, maintained by the pageout code. An inactive_ratio * of 3 means 3:1 or 25% of the pages are kept on the inactive list. * * total target max diff --git a/mm/vmstat.c b/mm/vmstat.c index 7255c0a2a972..89d29802e709 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1682,11 +1682,9 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat, } seq_printf(m, "\n node_unreclaimable: %u" - "\n start_pfn: %lu" - "\n node_inactive_ratio: %u", + "\n start_pfn: %lu", pgdat->kswapd_failures >= MAX_RECLAIM_RETRIES, - zone->zone_start_pfn, - zone->zone_pgdat->inactive_ratio); + zone->zone_start_pfn); seq_putc(m, '\n'); } -- 2.13.6