From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155AbdJCQ3N (ORCPT ); Tue, 3 Oct 2017 12:29:13 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58108 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751964AbdJCQ3L (ORCPT ); Tue, 3 Oct 2017 12:29:11 -0400 Date: Tue, 3 Oct 2017 18:29:20 +0200 From: Greg KH To: sunil.m@techveda.org Cc: gilad@benyossef.com, linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, karthik@techveda.org Subject: Re: [PATCH v2] staging: ccree: Convert to platform_{get,set}_drvdata() Message-ID: <20171003162920.GA11186@kroah.com> References: <1505993344-18304-1-git-send-email-sunil.m@techveda.org> <1505996262-19137-1-git-send-email-sunil.m@techveda.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505996262-19137-1-git-send-email-sunil.m@techveda.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 21, 2017 at 05:47:42PM +0530, sunil.m@techveda.org wrote: > From: Suniel Mahesh > > Platform devices are expected to use wrapper functions, > platform_{get,set}_drvdata() with platform_device as argument, > for getting and setting the driver data. dev_{get,set}_drvdata() > are using &plat_dev->dev. > For wrapper functions we can directly pass a struct platform_device. > > dev_set_drvdata() is redundant and therefore removed. The driver core > clears the driver data to NULL after device_release or on probe failure. > > Signed-off-by: Suniel Mahesh > --- > Changes for v2: > - Rebased on top of staging-testing. Can you rebase again, this still does not apply :(