mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alfonso Lima Astor <alfonsolimaastor@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: diferenciate between buffer and data types to fix sparse warning
Date: Tue, 3 Oct 2017 18:34:12 +0200	[thread overview]
Message-ID: <20171003163412.GA16638@kroah.com> (raw)
In-Reply-To: <1506532578-9261-1-git-send-email-alfonsolimaastor@gmail.com>

On Wed, Sep 27, 2017 at 06:16:18PM +0100, Alfonso Lima Astor wrote:
> sparse was complaning about an incorrect type cast:
> drivers/staging/fbtft/fbtft-bus.c:60:1: warning: incorrect type in assignment (different base types)
> drivers/staging/fbtft/fbtft-bus.c:60:1:    expected unsigned short [unsigned] [short] [usertype] <noident>
> drivers/staging/fbtft/fbtft-bus.c:60:1:    got restricted __be16 [usertype] <noident>
> drivers/staging/fbtft/fbtft-bus.c:60:1: warning: incorrect type in assignment (different base types)
> drivers/staging/fbtft/fbtft-bus.c:60:1:    expected unsigned short [unsigned] [short] [usertype] <noident>
> drivers/staging/fbtft/fbtft-bus.c:60:1:    got restricted __be16 [usertype] <noident>
> 
> The solution is to add an extra parameter to the macro to
> diferenciate between buffer type and data type.

Ugh, messy.  Please resend and cc: the maintainers of this driver/code
so that they can verify this is correct.  As it is, I have no way of
determining that...

thanks,

greg k-h

      reply	other threads:[~2017-10-03 16:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27 17:16 Alfonso Lima Astor
2017-10-03 16:34 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171003163412.GA16638@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alfonsolimaastor@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome