From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752150AbdJCQow (ORCPT ); Tue, 3 Oct 2017 12:44:52 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35982 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064AbdJCQou (ORCPT ); Tue, 3 Oct 2017 12:44:50 -0400 X-Google-Smtp-Source: AOwi7QAW9iajn/0/Cgb/8Hd1emuePqHKDuyXf++/sxj9ekNvV5evoEaRujtaaT115EVQD6RvUtJRFw== Date: Tue, 3 Oct 2017 19:44:48 +0300 From: "Kirill A. Shutemov" To: Zi Yan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A . Shutemov" , Abdul Haleem , Anshuman Khandual , Zi Yan , Andrew Morton , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] mm: remove unnecessary WARN_ONCE in page_vma_mapped_walk(). Message-ID: <20171003164448.gasvu5iu3xaoscgo@node.shutemov.name> References: <20171003142606.12324-1-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171003142606.12324-1-zi.yan@sent.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 03, 2017 at 10:26:06AM -0400, Zi Yan wrote: > From: Zi Yan > > A non present pmd entry can appear after pmd_lock is taken in > page_vma_mapped_walk(), even if THP migration is not enabled. > The WARN_ONCE is unnecessary. > > Fixes: 616b8371539a ("mm: thp: enable thp migration in generic path") > Reported-and-tested-by: Abdul Haleem > Signed-off-by: Zi Yan > Cc: "Kirill A. Shutemov" > Cc: Anshuman Khandual > Cc: Andrew Morton Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov