From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751148AbdJCSYM (ORCPT ); Tue, 3 Oct 2017 14:24:12 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40370 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbdJCSYJ (ORCPT ); Tue, 3 Oct 2017 14:24:09 -0400 Date: Tue, 3 Oct 2017 20:24:17 +0200 From: Greg Kroah-Hartman To: Martyn Welch Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2] Use RX_BUF_SIZE to set size of RX buffer Message-ID: <20171003182417.GB19258@kroah.com> References: <1506593260-14457-1-git-send-email-martyn.welch@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1506593260-14457-1-git-send-email-martyn.welch@collabora.co.uk> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 28, 2017 at 11:07:40AM +0100, Martyn Welch wrote: > The imx serial driver uses PAGE_SIZE when allocating rx_buf, but then > uses RX_BUF_SIZE (which is currently defined as PAGE_SIZE) to describe > the length of the buffer when initialising the scatter gather list. > > In order to ensure that this stays consistent, use RX_BUF_SIZE in both > locations. > > Signed-off-by: Martyn Welch > Acked-by: Uwe Kleine-König > --- > > v2: Add missing SoB and Uwe's Acked-by. Your subject is missing "serial: imx:" :( I'll go fix it up...