From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751263AbdJCS1s (ORCPT ); Tue, 3 Oct 2017 14:27:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40962 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbdJCS1q (ORCPT ); Tue, 3 Oct 2017 14:27:46 -0400 Date: Tue, 3 Oct 2017 20:27:55 +0200 From: Greg Kroah-Hartman To: Martyn Welch Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: imx: Correct comment imx_flush_buffer() Message-ID: <20171003182755.GA32455@kroah.com> References: <1506676939-20940-1-git-send-email-martyn.welch@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506676939-20940-1-git-send-email-martyn.welch@collabora.co.uk> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 29, 2017 at 10:22:19AM +0100, Martyn Welch wrote: > The comment in imx_flush_buffer() states that the state of 4 registers > are to be saved/restored, then only saves and restores 3 registers. The > missing register (UBRC) is read only and thus can't be restored. > > Update the comment to reflect reality. Always run checkpatch.pl so you don't get grumpy maintainers telling you to run checkpatch.pl :(