From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751226AbdJCTWg (ORCPT ); Tue, 3 Oct 2017 15:22:36 -0400 Received: from outbound-smtp14.blacknight.com ([46.22.139.231]:35870 "EHLO outbound-smtp14.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbdJCTWg (ORCPT ); Tue, 3 Oct 2017 15:22:36 -0400 Date: Tue, 3 Oct 2017 20:22:33 +0100 From: Mel Gorman To: Andrey Ryabinin Cc: Andrew Morton , Kemi Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/mempolicy: fix NUMA_INTERLEAVE_HIT counter Message-ID: <20171003192233.6drmrp5huoxpctah@techsingularity.net> References: <20171003164720.22130-1-aryabinin@virtuozzo.com> <20171003191003.8573-1-aryabinin@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20171003191003.8573-1-aryabinin@virtuozzo.com> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 03, 2017 at 10:10:03PM +0300, Andrey Ryabinin wrote: > Commit 3a321d2a3dde separated NUMA counters from zone counters, but > the NUMA_INTERLEAVE_HIT call site wasn't updated to use the new interface. > So alloc_page_interleave() actually increments NR_ZONE_INACTIVE_FILE > instead of NUMA_INTERLEAVE_HIT. > > Fix this by using __inc_numa_state() interface to increment > NUMA_INTERLEAVE_HIT. > > Fixes: 3a321d2a3dde ("mm: change the call sites of numa statistics items") > Signed-off-by: Andrey Ryabinin Acked-by: Mel Gorman -- Mel Gorman SUSE Labs