From: Steven Rostedt <rostedt@goodmis.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event
Date: Tue, 3 Oct 2017 20:00:34 -0400 [thread overview]
Message-ID: <20171003200034.45889486@gandalf.local.home> (raw)
In-Reply-To: <765df45e-18f0-3d3d-29c6-42f850b3b826@siemens.com>
On Fri, 29 Sep 2017 13:29:16 +0200
Jan Kiszka <jan.kiszka@siemens.com> wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Seems like a copy&paste bug of the initial commit 7b0139ebb1cf.
Thanks, applied!
-- Steve
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> I didn't manage to test this so far, but this looked strange while
> reading the code.
>
> trace-view-store.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/trace-view-store.c b/trace-view-store.c
> index 2ec52c8..f5d0a04 100644
> --- a/trace-view-store.c
> +++ b/trace-view-store.c
> @@ -1254,7 +1254,7 @@ static void update_filter_tasks(TraceViewStore *store)
> "pid");
>
> store->sched_wakeup_new_event =
> - pevent_find_event_by_name(pevent, "sched", "sched_wakeup");
> + pevent_find_event_by_name(pevent, "sched", "sched_wakeup_new");
> if (store->sched_wakeup_new_event)
> store->sched_wakeup_new_pid_field =
> pevent_find_any_field(store->sched_wakeup_new_event,
prev parent reply other threads:[~2017-10-04 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 11:29 Jan Kiszka
2017-09-29 11:49 ` Jan Kiszka
2017-09-29 13:01 ` Steven Rostedt
2017-10-04 0:00 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003200034.45889486@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®