From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Daniel Drake <drake@endlessm.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
x86@kernel.org, linux-wireless@vger.kernel.org,
ath9k-devel@qca.qualcomm.com, linux@endlessm.com
Subject: Re: [PATCH] PCI MSI: allow alignment restrictions on vector allocation
Date: Tue, 3 Oct 2017 16:34:34 -0500 [thread overview]
Message-ID: <20171003213434.GI25517@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1710032306170.2278@nanos>
On Tue, Oct 03, 2017 at 11:07:58PM +0200, Thomas Gleixner wrote:
> On Mon, 2 Oct 2017, Thomas Gleixner wrote:
> > On Mon, 2 Oct 2017, Thomas Gleixner wrote:
> > > On Mon, 2 Oct 2017, Daniel Drake wrote:
> > > 2) The affinity setting of straight MSI interrupts (w/o remapping) on x86
> > > requires to make the affinity change from the interrupt context of the
> > > current active vector in order not to lose interrupts or worst case
> > > getting into a stale state.
> > >
> > > That works for single vectors, but trying to move all vectors in one
> > > go is more or less impossible, as there is no reliable way to
> > > determine that none of the other vectors is on flight.
> > >
> > > There might be some 'workarounds' for that, but I rather avoid that
> > > unless we get an official documented one from Intel/AMD.
> >
> > Thinking more about it. That might be actually a non issue for MSI, but we
> > have that modus operandi in the current code and we need to address that
> > first before even thinking about multi MSI support.
>
> But even if its possible, it's very debatable whether it's worth the effort
> when this driver just can use the legacy INTx.and be done with it.
Daniel said "Legacy interrupts do not work on that module, so MSI
support is required," so I assume he means INTx doesn't work. Maybe
the driver could poll? I don't know how much slower that would be,
but at least it would penalize the broken device, not everybody.
Bjorn
next prev parent reply other threads:[~2017-10-03 21:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170925041153.26574-1-drake@endlessm.com>
2017-09-27 15:28 ` Thomas Gleixner
2017-10-02 8:57 ` Daniel Drake
2017-10-02 14:38 ` Thomas Gleixner
2017-10-02 16:19 ` Thomas Gleixner
2017-10-03 21:07 ` Thomas Gleixner
2017-10-03 21:34 ` Bjorn Helgaas [this message]
2017-10-03 21:46 ` Thomas Gleixner
2017-10-05 4:23 ` Daniel Drake
2017-10-05 10:13 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003213434.GI25517@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=drake@endlessm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®