From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751185AbdJDRcR (ORCPT ); Wed, 4 Oct 2017 13:32:17 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:48368 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbdJDRcQ (ORCPT ); Wed, 4 Oct 2017 13:32:16 -0400 Date: Wed, 04 Oct 2017 10:32:15 -0700 (PDT) Message-Id: <20171004.103215.1424926789610505281.davem@davemloft.net> To: colin.king@canonical.com Cc: leedom@chelsio.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cxgb4vf: make a couple of functions static From: David Miller In-Reply-To: <20171004132037.6409-1-colin.king@canonical.com> References: <20171004132037.6409-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Oct 2017 10:32:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Wed, 4 Oct 2017 14:20:37 +0100 > From: Colin Ian King > > The functions t4vf_link_down_rc_str and t4vf_handle_get_port_info are > local to the source and do not need to be in global scope, so make > them static. > > Cleans up sparse warnings: > symbol 't4vf_link_down_rc_str' was not declared. Should it be static? > symbol 't4vf_handle_get_port_info' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Applied to net-next, thanks.