From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751296AbdJDRod (ORCPT ); Wed, 4 Oct 2017 13:44:33 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:48584 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbdJDRoc (ORCPT ); Wed, 4 Oct 2017 13:44:32 -0400 Date: Wed, 04 Oct 2017 10:44:30 -0700 (PDT) Message-Id: <20171004.104430.371058999122748879.davem@davemloft.net> To: mka@chromium.org Cc: jakub.kicinski@netronome.com, simon.horman@netronome.com, dirk.vandermerwe@netronome.com, oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, renato.golin@linaro.org, manojgupta@chromium.org, groeck@chromium.org, dianders@chromium.org Subject: Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro From: David Miller In-Reply-To: <20171004174215.GM173745@google.com> References: <20171003200546.165731-1-mka@chromium.org> <20171003145000.53683e21@cakuba> <20171004174215.GM173745@google.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Oct 2017 10:44:31 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthias Kaehlcke Date: Wed, 4 Oct 2017 10:42:15 -0700 > Given that this doesn't seem to be a widespread issue in the kernel > personally I would consider the conversion to a macro in this case an > acceptable solution, though it is definitely ugly. However I'm not the > owner of the driver or the subsystem, so my opinion doesn't really > carry much weight here ;-) Losing type checking is a serious regression as far as I am concerned.