From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbdJDHU7 (ORCPT ); Wed, 4 Oct 2017 03:20:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:49895 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750945AbdJDHU6 (ORCPT ); Wed, 4 Oct 2017 03:20:58 -0400 Date: Wed, 4 Oct 2017 09:20:55 +0200 From: Jan Kara To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, jack@suse.cz Subject: Re: [PATCH 2/2] sysctl: remove /proc/sys/vm/nr_pdflush_threads Message-ID: <20171004072055.GO11879@quack2.suse.cz> References: <1507043781-2874-1-git-send-email-axboe@kernel.dk> <1507043781-2874-3-git-send-email-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507043781-2874-3-git-send-email-axboe@kernel.dk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 03-10-17 09:16:21, Jens Axboe wrote: > This tunable has been obsolete since 2.6.32, and writes to the > file have been failing and complaining in dmesg since then: > > nr_pdflush_threads exported in /proc is scheduled for removal > > That was 8 years ago. Remove the file ABI obsolete notice, and > the sysfs file. > > Signed-off-by: Jens Axboe Agreed. You can add: Reviewed-by: Jan Kara Honza > --- > Documentation/ABI/obsolete/proc-sys-vm-nr_pdflush_threads | 5 ----- > kernel/sysctl.c | 5 ----- > 2 files changed, 10 deletions(-) > delete mode 100644 Documentation/ABI/obsolete/proc-sys-vm-nr_pdflush_threads > > diff --git a/Documentation/ABI/obsolete/proc-sys-vm-nr_pdflush_threads b/Documentation/ABI/obsolete/proc-sys-vm-nr_pdflush_threads > deleted file mode 100644 > index b0b0eeb20fe3..000000000000 > --- a/Documentation/ABI/obsolete/proc-sys-vm-nr_pdflush_threads > +++ /dev/null > @@ -1,5 +0,0 @@ > -What: /proc/sys/vm/nr_pdflush_threads > -Date: June 2012 > -Contact: Wanpeng Li > -Description: Since pdflush is replaced by per-BDI flusher, the interface of old pdflush > - exported in /proc/sys/vm/ should be removed. > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 6648fbbb8157..a5dd8d82c253 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -1345,11 +1345,6 @@ static struct ctl_table vm_table[] = { > .extra1 = &zero, > }, > { > - .procname = "nr_pdflush_threads", > - .mode = 0444 /* read-only */, > - .proc_handler = pdflush_proc_obsolete, > - }, > - { > .procname = "swappiness", > .data = &vm_swappiness, > .maxlen = sizeof(vm_swappiness), > -- > 2.7.4 > -- Jan Kara SUSE Labs, CR