mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: linux-usb@vger.kernel.org
Cc: Andrey Konovalov <andreyknvl@google.com>,
	linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>,
	stable <stable@vger.kernel.org>
Subject: [PATCH 2/2] USB: serial: console: fix use-after-free after failed setup
Date: Wed,  4 Oct 2017 11:01:13 +0200	[thread overview]
Message-ID: <20171004090113.24218-3-johan@kernel.org> (raw)
In-Reply-To: <20171004090113.24218-1-johan@kernel.org>

Make sure to reset the USB-console port pointer when console setup fails
in order to avoid having the struct usb_serial be prematurely freed by
the console code when the device is later disconnected.

Fixes: 73e487fdb75f ("[PATCH] USB console: fix disconnection issues")
Cc: stable <stable@vger.kernel.org>	# 2.6.18
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/console.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
index ed8ba3ef5c79..43a862a90a77 100644
--- a/drivers/usb/serial/console.c
+++ b/drivers/usb/serial/console.c
@@ -186,6 +186,7 @@ static int usb_console_setup(struct console *co, char *options)
 	tty_kref_put(tty);
  reset_open_count:
 	port->port.count = 0;
+	info->port = NULL;
 	usb_autopm_put_interface(serial->interface);
  error_get_interface:
 	usb_serial_put(serial);
-- 
2.14.2

  parent reply	other threads:[~2017-10-04  9:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04  9:01 [PATCH 0/2] USB: serial: console: fix two use-after-free bugs Johan Hovold
2017-10-04  9:01 ` [PATCH 1/2] USB: serial: console: fix use-after-free on disconnect Johan Hovold
2017-10-04 14:39   ` Greg KH
2017-10-07  8:56   ` Jaejoong Kim
2017-10-09 10:41     ` Johan Hovold
2017-10-09 11:05   ` Andrey Konovalov
2017-10-09 11:10     ` Johan Hovold
2017-10-04  9:01 ` Johan Hovold [this message]
2017-10-04 14:39   ` [PATCH 2/2] USB: serial: console: fix use-after-free after failed setup Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004090113.24218-3-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=andreyknvl@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome