From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484AbdJDKRf (ORCPT ); Wed, 4 Oct 2017 06:17:35 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:35908 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbdJDKRd (ORCPT ); Wed, 4 Oct 2017 06:17:33 -0400 Date: Wed, 4 Oct 2017 11:17:20 +0100 From: Mark Brown To: Sandeep Patil Cc: Laura Abbott , devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, arve@android.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, riandrews@android.com, Benjamin Gaignard , linux-api@vger.kernel.org, sumit.semwal@linaro.org, dan.carpenter@oracle.com Subject: Re: [PATCH v5 2/2] staging: ion: create one device entry per heap Message-ID: <20171004101720.ob5f467tro7agpcz@sirena.co.uk> References: <1506518409-16887-1-git-send-email-benjamin.gaignard@linaro.org> <1506518409-16887-3-git-send-email-benjamin.gaignard@linaro.org> <2e15edc2-a17f-3930-7d5b-4b5b7d2e0a4d@redhat.com> <20171003164849.rcdgez6lbpmq5llt@sirena.org.uk> <2417c969-357f-d5d9-153a-2180d09b0dc6@redhat.com> <20171003230830.GA132839@sspatil-desktop.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="exh2ffqqp2s7yg46" Content-Disposition: inline In-Reply-To: <20171003230830.GA132839@sspatil-desktop.mtv.corp.google.com> X-Cookie: Body by Nautilus, Brain by Mattel. User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --exh2ffqqp2s7yg46 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 03, 2017 at 04:08:30PM -0700, Sandeep Patil wrote: > It is entirely possible and easy in android/ueventd to create those nodes > under "/dev/ion/". (assuming the heap 'subsystem' for these new devices will > point to 'ion'). The reason I didn't say /dev/ion/foo initially is that if people want to keep the existing /dev/ion around for compatibility reasons then the /dev/ion name isn't available which might cause issues. Otherwise just dumping everything under a directory (perhaps with a different name) was my first thought as well. > (Also FWIW, the SELinux permissions are also possible with the current ion > implementation by adding rules to disallow specific ioctls instead of adding > permissions to access device node as this change would do) AIUI the request is to limit access to specific heaps, and obviously not everyone wants to deal with SELinux at all. --exh2ffqqp2s7yg46 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlnUtS8ACgkQJNaLcl1U h9CgIQf/Y1PSlNGnz7Bx3jLxyK9RIsm7WLjJIpRvt9AOqr1OawEQCj08kCtIli7A sjaM9f/v2xozvoszlVABBqnwVlFcq3LWoxkCCN0Uzph2wwzlWvEIQOc1aqa72oyu YJ6S5w4faqcXbWlGcz30wZwMjMrKRL/jbKsGB60I1P0IH76CDafbFzssqBt9EZLW CwjSZNC6KMZ/PiGJHowtYFEQcSAyPGBDqWff/0L37/WhCkQqcSRAaxrI090o0lmD MIOcA2iq4yDDDkh0YRhabqhD4PT84AsQr6deYzogHvggzMJMqMaY7RrR6EPlAy5o 9D/X6EXvBP46f3NZlOhkpn49YtrNTg== =gJ2L -----END PGP SIGNATURE----- --exh2ffqqp2s7yg46--