From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751846AbdJDLJt (ORCPT ); Wed, 4 Oct 2017 07:09:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:38577 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751114AbdJDLJs (ORCPT ); Wed, 4 Oct 2017 07:09:48 -0400 Date: Wed, 4 Oct 2017 13:09:24 +0200 From: Borislav Petkov To: P J P Cc: Brijesh Singh , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 PATCH v4.1 07/29] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support Message-ID: <20171004110923.onuz7uavcbao4nbn@pd.tnic> References: <20170919204627.3875-8-brijesh.singh@amd.co> <20171002204831.5947-1-brijesh.singh@amd.com> <20171004092152.4lmjlsqrg25dgaxu@pd.tnic> <20171004100749.433dzszyea3oqcpn@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 04, 2017 at 04:12:37PM +0530, P J P wrote: > Quick glance would work if it is readable. Currently it is not if > one is viewing it in 80 cols screen/window. They do that. Writing > return on the same line does not add specific value IMO. Then you'll have to scroll to the right like you have to do for the gazillion other places where the 80 cols rule is overridden for readability or string grepping or other reasons. Or you should widen your windows. > Up to you; I pointed it out as 80 columns rule makes sense to me. It is up to the crypto maintainer in the end. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --