From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751441AbdJDQoS (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Oct 2017 12:44:18 -0400
Received: from mail.kernel.org ([198.145.29.99]:44102 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750966AbdJDQoR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Oct 2017 12:44:17 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CEE821883
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
Date: Wed, 4 Oct 2017 12:44:14 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Joel Fernandes <joelaf@google.com>, linux-kernel@vger.kernel.org,
        kernel-team@android.com
Subject: Re: [PATCH v7 2/2] tracing: Add support for preempt and irq
 enable/disable events
Message-ID: <20171004124414.43115067@gandalf.local.home>
In-Reply-To: <20171004160434.hfd7rbefqvi3lz22@hirez.programming.kicks-ass.net>
References: <20170929212245.24168-1-joelaf@google.com>
        <20170929212245.24168-2-joelaf@google.com>
        <20171004160434.hfd7rbefqvi3lz22@hirez.programming.kicks-ass.net>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 4 Oct 2017 18:04:34 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, Sep 29, 2017 at 02:22:45PM -0700, Joel Fernandes wrote:
> > +++ b/kernel/trace/trace_irqsoff.c  
> 
> >  EXPORT_SYMBOL(trace_hardirqs_on);
> >  EXPORT_SYMBOL(trace_hardirqs_off);
> >  EXPORT_SYMBOL(trace_hardirqs_on_caller);
> >  EXPORT_SYMBOL(trace_hardirqs_off_caller);  
> 
> Steve, how does this compiler with lockdep enabled? Because:
> 
> kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_on_caller);
> kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_on);
> kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_off_caller);
> kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_off);

I'll have to see if it does, I haven't applied them yet. Looks like
they were removed from the:

#ifdef CONFIG_PROVE_LOCKING

[..]

#else /* !CONFIG_PROVE_LOCKING */

<here>

#endif


I don't see the protection in the patches. I will definitely test that
before pushing it anywhere.

-- Steve