From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751400AbdJDRDy (ORCPT ); Wed, 4 Oct 2017 13:03:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:45598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbdJDRDx (ORCPT ); Wed, 4 Oct 2017 13:03:53 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB02721869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 4 Oct 2017 13:03:51 -0400 From: Steven Rostedt To: Joel Fernandes Cc: Peter Zijlstra , LKML , kernel-team@android.com Subject: Re: [PATCH v7 2/2] tracing: Add support for preempt and irq enable/disable events Message-ID: <20171004130351.7a24d0ba@gandalf.local.home> In-Reply-To: References: <20170929212245.24168-1-joelaf@google.com> <20170929212245.24168-2-joelaf@google.com> <20171004160434.hfd7rbefqvi3lz22@hirez.programming.kicks-ass.net> <20171004124414.43115067@gandalf.local.home> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Oct 2017 09:56:33 -0700 Joel Fernandes wrote: > > I don't see the protection in the patches. I will definitely test that > > before pushing it anywhere. > > The protection added by CONFIG_PROVE_LOCKING was already there before > my patches. I just moved the code around in patch 1/2, nothing changed > in that patch. I already tested the combination of PROVE_LOCKING > enabled and disabled and several other combinations on your -next > tree. It all compiled fine. Here is my test script FWIW: > (By the way, do you mean that another tree/branch than your -next or > Linus's master has protection removed? If so, could you let me know > which tree/branch?) Using Linus's master is usually fine, but if you want to see what I'm working on, just look at the ftrace/core branch of my linux-trace.git tree on kernel.org. Note, that branch often rebases. My for-next branch does not. Also note, I'm currently looking to pull in Tom Zanussi's hist patch series, and then I'll get to yours afterward. -- Steve