From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752414AbdJDNzp (ORCPT ); Wed, 4 Oct 2017 09:55:45 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:42202 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752248AbdJDNzn (ORCPT ); Wed, 4 Oct 2017 09:55:43 -0400 Date: Wed, 4 Oct 2017 06:55:41 -0700 From: Matthew Wilcox To: Eric Dumazet Cc: Mateusz Guzik , Al Viro , mszeredi@redhat.com, linux-fsdevel@vger.kernel.org, LKML Subject: Re: [PATCH 2/2] vfs: grab the lock instead of blocking in __fd_install during resizing Message-ID: <20171004135541.GA22253@bombadil.infradead.org> References: <1507028295-9353-1-git-send-email-mguzik@redhat.com> <1507028295-9353-3-git-send-email-mguzik@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 03, 2017 at 07:41:11AM -0700, Eric Dumazet wrote: > On Tue, Oct 3, 2017 at 3:58 AM, Mateusz Guzik wrote: > > Explicit locking in the fallback case provides a safe state of the > > table. Getting rid of blocking semantics makes __fd_install usable > > again in non-sleepable contexts, which easies backporting efforts. > > > > There is a side effect of slightly nicer assembly for the common case > > as might_sleep can now be removed. > > > > Signed-off-by: Mateusz Guzik > > --- > > Documentation/filesystems/porting | 4 ---- > > fs/file.c | 11 +++++++---- > > 2 files changed, 7 insertions(+), 8 deletions(-) > > Nice change ! > > Reviewed-by: Eric Dumazet Hey Eric, Any chance you could review the patches from Sandhya that make this entire codepath obsolete? https://lkml.org/lkml/2017/4/29/20