From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751231AbdJDTRb convert rfc822-to-8bit (ORCPT ); Wed, 4 Oct 2017 15:17:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:57532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbdJDTR3 (ORCPT ); Wed, 4 Oct 2017 15:17:29 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA82A21869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 4 Oct 2017 15:17:27 -0400 From: Steven Rostedt To: Scott Wood Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] ktest: Use config-bisect.pl in ktest.pl Message-ID: <20171004151727.5304e7ba@gandalf.local.home> In-Reply-To: <1505425272.2772.9.camel@redhat.com> References: <20170717001630.10518-1-swood@redhat.com> <20170717001630.10518-8-swood@redhat.com> <1505425272.2772.9.camel@redhat.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Sep 2017 14:41:12 -0700 Scott Wood wrote: > On Sun, 2017-07-16 at 19:16 -0500, Scott Wood wrote: > > Reduce code duplication and take advantage of bisection logic > > improvements by calling config-bisect.pl. > > > > The output of make oldconfig is now copied directly to the desired > > file, > > rather than doing assign_configs+save_config, in order to preserve the > > ordering so that diffing the configs at the end will provide useful > > output. > > > > Signed-off-by: Scott Wood > > --- > >  tools/testing/ktest/ktest.pl | 247 +++++----------------------------- > > Any comments on this patchset? Finally got around to looking at it. Sorry for the late reply. I didn't see anything to concerning in patches 1-7 and applied them. I'll start testing them soon too. -- Steve