From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752522AbdJDPgN (ORCPT ); Wed, 4 Oct 2017 11:36:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58764 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752413AbdJDPgL (ORCPT ); Wed, 4 Oct 2017 11:36:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 62657C059B8D Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Wed, 4 Oct 2017 10:36:10 -0500 From: Josh Poimboeuf To: Guenter Roeck Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/kvm: Move kvm_fastop_exception to .fixup section Message-ID: <20171004153610.b2vuraixglgqbfz6@treble> References: <20171004151636.GA30935@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171004151636.GA30935@roeck-us.net> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 04 Oct 2017 15:36:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 04, 2017 at 08:16:36AM -0700, Guenter Roeck wrote: > On Wed, Oct 04, 2017 at 09:43:06AM -0500, Josh Poimboeuf wrote: > > When compiling the kernel with the '-frecord-gcc-switches' flag, objtool > > complains: > > > > arch/x86/kvm/emulate.o: warning: objtool: .GCC.command.line+0x0: special: can't find new instruction > > > > And also the kernel fails to link. > > > > The problem is that the 'kvm_fastop_exception' code gets placed into the > > throwaway '.GCC.command.line' section instead of '.text'. > > > > Exception fixup code is conventionally placed in the '.fixup' section, > > so put it there where it belongs. > > > > Reported-and-tested-by: Guenter Roeck > > Signed-off-by: Josh Poimboeuf > > Thanks! I forgot to add the kvm maintainers to CC. Will resend. -- Josh