From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751247AbdJDQEn (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Oct 2017 12:04:43 -0400
Received: from merlin.infradead.org ([205.233.59.134]:49078 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750966AbdJDQEm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Oct 2017 12:04:42 -0400
Date: Wed, 4 Oct 2017 18:04:34 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Joel Fernandes <joelaf@google.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v7 2/2] tracing: Add support for preempt and irq
 enable/disable events
Message-ID: <20171004160434.hfd7rbefqvi3lz22@hirez.programming.kicks-ass.net>
References: <20170929212245.24168-1-joelaf@google.com>
 <20170929212245.24168-2-joelaf@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170929212245.24168-2-joelaf@google.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 29, 2017 at 02:22:45PM -0700, Joel Fernandes wrote:
> +++ b/kernel/trace/trace_irqsoff.c

>  EXPORT_SYMBOL(trace_hardirqs_on);
>  EXPORT_SYMBOL(trace_hardirqs_off);
>  EXPORT_SYMBOL(trace_hardirqs_on_caller);
>  EXPORT_SYMBOL(trace_hardirqs_off_caller);

Steve, how does this compiler with lockdep enabled? Because:

kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_on_caller);
kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_on);
kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_off_caller);
kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_off);