From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751233AbdJDSbM (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Oct 2017 14:31:12 -0400
Received: from mail-pg0-f67.google.com ([74.125.83.67]:34881 "EHLO
        mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750779AbdJDSbL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Oct 2017 14:31:11 -0400
X-Google-Smtp-Source: AOwi7QCzwFvKyAgvud/f2t1Kv6nC4oJOAuxphq1UM70BtP2FNDMOfnS5qkhhxEPlNoneSAw+sIaeLw==
Date: Wed, 4 Oct 2017 11:31:08 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH] arm64: Enforce endianness build flags for LD and AS
Message-ID: <20171004183108.GA10699@roeck-us.net>
References: <1507064302-3972-1-git-send-email-linux@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1507064302-3972-1-git-send-email-linux@roeck-us.net>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 03, 2017 at 01:58:22PM -0700, Guenter Roeck wrote:
> If LD or AS is specified on the command line using "make LD=<my-ld>",
> the endianness flag will not be added. Depending on the toolchain used,
> this can result in endianness mismatch errors, such as
> 
> aarch64-cros-linux-gnu/binutils-bin/2.27.0/ld.bfd.real:
> arch/arm64/crypto/.tmp_aes-ce-cipher.o:
> 	compiled for a big endian system and target is little endian
> 
> The problem was observed when using the Chrome OS build system (which sets
> LD on the command line) for an arm64:allmodconfig build.
> 
> Use the override flag for both LD and AS to ensure that the endianness
> flag is always set.
> 
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Please ignore this patch for now; it doesn't help with my problem. Not yet
sure what happens, but it appears that "-EB" doesn't make it into the LD
variable used by cmd_make_builtin in scripts/Makefile.build. I'll have
to figure out what is going on.

Thanks,
Guenter

> ---
>  arch/arm64/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index 939b310913cf..d780d00bea9c 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -56,15 +56,15 @@ KBUILD_AFLAGS	+= $(call cc-option,-mabi=lp64)
>  ifeq ($(CONFIG_CPU_BIG_ENDIAN), y)
>  KBUILD_CPPFLAGS	+= -mbig-endian
>  CHECKFLAGS	+= -D__AARCH64EB__
> -AS		+= -EB
> -LD		+= -EB
> +override AS		+= -EB
> +override LD		+= -EB
>  LDFLAGS		+= -maarch64linuxb
>  UTS_MACHINE	:= aarch64_be
>  else
>  KBUILD_CPPFLAGS	+= -mlittle-endian
>  CHECKFLAGS	+= -D__AARCH64EL__
> -AS		+= -EL
> -LD		+= -EL
> +override AS		+= -EL
> +override LD		+= -EL
>  LDFLAGS		+= -maarch64linux
>  UTS_MACHINE	:= aarch64
>  endif
> -- 
> 2.7.4
>