From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751554AbdJEQxN (ORCPT ); Thu, 5 Oct 2017 12:53:13 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:45992 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbdJEQxL (ORCPT ); Thu, 5 Oct 2017 12:53:11 -0400 Date: Thu, 05 Oct 2017 09:53:09 -0700 (PDT) Message-Id: <20171005.095309.1742522481534840543.davem@davemloft.net> To: pebolle@tiscali.nl Cc: keescook@chromium.org, isdn@linux-pingi.de, johan@kernel.org, gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] isdn/gigaset: Convert timers to use timer_setup() From: David Miller In-Reply-To: <1507190336.2167.5.camel@tiscali.nl> References: <20171005005212.GA23556@beast> <1507190336.2167.5.camel@tiscali.nl> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Oct 2017 09:53:10 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paul Bolle Date: Thu, 05 Oct 2017 09:58:56 +0200 > Hi Kees, > > On Wed, 2017-10-04 at 17:52 -0700, Kees Cook wrote: >> Also uses kzmalloc to replace open-coded field assignments to NULL and zero. > > If I'm allowed to whine (chances that I'm allowed to do that are not so great > as Dave tends to apply gigaset patches before I even have a chance to look at > them properly!): I'd prefer it if that was done separately in a preceding > patch. Would that bother you? Agreed, these timer transformations are already exhausting to review without unrelated modifications sneaking in.