From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751484AbdJFBFu (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Oct 2017 21:05:50 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:54660 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751083AbdJFBFs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Oct 2017 21:05:48 -0400
Date: Thu, 05 Oct 2017 18:05:39 -0700 (PDT)
Message-Id: <20171005.180539.381799694621402344.davem@davemloft.net>
To: bjorn.andersson@linaro.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, clew@codeaurora.org
Subject: Re: [RESEND PATCH 7/7] net: qrtr: Support decoding incoming v2
 packets
From: David Miller <davem@davemloft.net>
In-Reply-To: <20171005035105.14677-8-bjorn.andersson@linaro.org>
References: <20171005035105.14677-1-bjorn.andersson@linaro.org>
        <20171005035105.14677-8-bjorn.andersson@linaro.org>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Oct 2017 18:05:42 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Bjorn Andersson <bjorn.andersson@linaro.org>
Date: Wed,  4 Oct 2017 20:51:05 -0700

> +/**
> + * struct qrtr_hdr_v2 - (I|R)PCrouter packet header later versions
> + * @version: protocol version
> + * @type: packet type; one of QRTR_TYPE_*
> + * @flags: bitmask of QRTR_FLAGS_*
> + * @optlen: length of optional header data
> + * @size: length of packet, excluding this header and optlen
> + * @src_node_id: source node
> + * @src_port_id: source port
> + * @dst_node_id: destination node
> + * @dst_port_id: destination port
> + */
> +struct qrtr_hdr_v2 {
> +	u8 version;
> +	u8 type;
> +	u8 flags;
> +	u8 optlen;
> +	__le32 size;
> +	__le16 src_node_id;
> +	__le16 src_port_id;
> +	__le16 dst_node_id;
> +	__le16 dst_port_id;
> +} __packed;

__packed should be only used when it is provably necessary, and it
should not be needed here.