From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751518AbdJFE1P (ORCPT ); Fri, 6 Oct 2017 00:27:15 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57386 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732AbdJFE1N (ORCPT ); Fri, 6 Oct 2017 00:27:13 -0400 Date: Thu, 05 Oct 2017 21:27:12 -0700 (PDT) Message-Id: <20171005.212712.1114511156589357681.davem@davemloft.net> To: colin.king@canonical.com Cc: timur@codeaurora.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: qcom/emac: make function emac_isr static From: David Miller In-Reply-To: <20171005091023.27781-1-colin.king@canonical.com> References: <20171005091023.27781-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Oct 2017 21:27:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Thu, 5 Oct 2017 10:10:23 +0100 > From: Colin Ian King > > The function emac_isr is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warnings: > symbol 'emac_isr' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Applied.