From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751526AbdJFFSX (ORCPT ); Fri, 6 Oct 2017 01:18:23 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57994 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbdJFFSW (ORCPT ); Fri, 6 Oct 2017 01:18:22 -0400 Date: Thu, 05 Oct 2017 22:18:21 -0700 (PDT) Message-Id: <20171005.221821.1101136936795374969.davem@davemloft.net> To: devtimhansen@gmail.com Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.levin@one.verizon.com Subject: Re: [PATCH] net/ipv6: remove unused err variable on icmpv6_push_pending_frames From: David Miller In-Reply-To: <20171005194532.GA126147@debian> References: <20171005194532.GA126147@debian> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Oct 2017 22:18:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tim Hansen Date: Thu, 5 Oct 2017 15:45:32 -0400 > int err is unused by icmpv6_push_pending_frames(), this patch returns removes the variable and returns the function with 0. > > git bisect shows this variable has been around since linux has been in git in commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2. > > This was found by running make coccicheck M=net/ipv6/ on linus' tree on commit 77ede3a014a32746002f7889211f0cecf4803163 (current HEAD as of this patch). > > Signed-off-by: Tim Hansen Applied.