From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372AbdJEMue (ORCPT ); Thu, 5 Oct 2017 08:50:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:55760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbdJEMuc (ORCPT ); Thu, 5 Oct 2017 08:50:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C15921883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Thu, 5 Oct 2017 08:50:29 -0400 From: Steven Rostedt To: Scott Wood Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] ktest: Use config-bisect.pl in ktest.pl Message-ID: <20171005085029.56ff06eb@gandalf.local.home> In-Reply-To: <1507148663.2256.26.camel@redhat.com> References: <20170717001630.10518-1-swood@redhat.com> <20170717001630.10518-8-swood@redhat.com> <20171004151832.512f774e@gandalf.local.home> <1507148663.2256.26.camel@redhat.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 Oct 2017 15:24:23 -0500 Scott Wood wrote: > On Wed, 2017-10-04 at 15:18 -0400, Steven Rostedt wrote: > > On Sun, 16 Jul 2017 19:16:30 -0500 > > Scott Wood wrote: > > > > > Reduce code duplication and take advantage of bisection logic > > > improvements by calling config-bisect.pl. > > > > > > The output of make oldconfig is now copied directly to the desired > > > file, > > > rather than doing assign_configs+save_config, in order to preserve > > > the > > > ordering so that diffing the configs at the end will provide useful > > > output. > > > > The reason I never did this, was that I copy ktest.pl all over the > > place :-/ I need it to be a stand alone. I don't copy config-bisect > > around. Not sure how to deal with this. > > By "this" I assume you mean using the external config-bisect code, > rather than the part about copying oldconfig output? > > The options I can see are to copy both files as a group (possibly making > that easier by renaming config-bisect.pl to ktest-conf-bisect.pl, so you > can "cp tools/testing/ktest/ktest*.pl "), or just living with code > duplication. In a previous discussion you suggested you preferred that > latter option, though in that case the config bisect logic changes > should ideally be done before the fork. I don't want to rename it. I like the simply "config-bisect.pl" name. > > It should also be noted that ktest.pl only depends on config-bisect.pl > if a config bisect is being performed, so other ktest.pl functions still > work standalone. I thought about this too, and may be able to live with that. Perhaps we should make the config-bisect internals into something that can be a perl library, and be able to place that someplace that both could use? -- Steve