From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557AbdJEKKT (ORCPT ); Thu, 5 Oct 2017 06:10:19 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35819 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbdJEKKQ (ORCPT ); Thu, 5 Oct 2017 06:10:16 -0400 X-Google-Smtp-Source: AOwi7QAskjjpBqDMQhbcgVQu1rttObMYmCVnUokrXlhy/o57pTC7ck8hBWZz4R2vcqNN5+AhVj4eVw== Date: Thu, 5 Oct 2017 13:10:13 +0300 From: "Kirill A. Shutemov" To: Mike Kravetz Cc: "Kirill A. Shutemov" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Michal Hocko Subject: Re: [PATCH 1/2] mm: Introduce wrapper to access mm->nr_ptes Message-ID: <20171005101013.hdf7hjkcl4l7aw2a@node.shutemov.name> References: <20171004163648.11234-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 04, 2017 at 11:35:47AM -0700, Mike Kravetz wrote: > On 10/04/2017 09:36 AM, Kirill A. Shutemov wrote: > > @@ -813,7 +813,7 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p, > > init_rwsem(&mm->mmap_sem); > > INIT_LIST_HEAD(&mm->mmlist); > > mm->core_state = NULL; > > - atomic_long_set(&mm->nr_ptes, 0); > > + mm_nr_ptes_init(mm); > > mm_nr_pmds_init(mm); > > mm_nr_puds_init(mm); > > mm->map_count = 0; > > @@ -869,9 +869,9 @@ static void check_mm(struct mm_struct *mm) > > "mm:%p idx:%d val:%ld\n", mm, i, x); > > } > > > > - if (atomic_long_read(&mm->nr_ptes)) > > + if (mm_nr_pmds(mm)) > > Should that be? > > if (mm_nr_ptes(mm)) Thanks, for catching this. -- Kirill A. Shutemov