From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751774AbdJELpu (ORCPT ); Thu, 5 Oct 2017 07:45:50 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:44026 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751500AbdJELpj (ORCPT ); Thu, 5 Oct 2017 07:45:39 -0400 From: Brendan Jackman To: linux-kernel@vger.kernel.org, Peter Zijlstra Cc: Dietmar Eggemann , Vincent Guittot , Josef Bacik , Ingo Molnar , Morten Rasmussen Subject: [PATCH RESEND v3 3/5] sched/fair: Fix find_idlest_group when local group is not allowed Date: Thu, 5 Oct 2017 12:45:14 +0100 Message-Id: <20171005114516.18617-4-brendan.jackman@arm.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171005114516.18617-1-brendan.jackman@arm.com> References: <20171005114516.18617-1-brendan.jackman@arm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the local group is not allowed we do not modify this_*_load from their initial value of 0. That means that the load checks at the end of find_idlest_group cause us to incorrectly return NULL. Fixing the initial values to ULONG_MAX means we will instead return the idlest remote group in that case. Signed-off-by: Brendan Jackman Cc: Dietmar Eggemann Cc: Vincent Guittot Cc: Josef Bacik Cc: Ingo Molnar Cc: Morten Rasmussen Cc: Peter Zijlstra Reviewed-by: Vincent Guittot Reviewed-by: Josef Bacik --- kernel/sched/fair.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 8b12c76a8b62..933f5c9d95d1 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -5775,8 +5775,9 @@ find_idlest_group(struct sched_domain *sd, struct task_struct *p, { struct sched_group *idlest = NULL, *group = sd->groups; struct sched_group *most_spare_sg = NULL; - unsigned long min_runnable_load = ULONG_MAX, this_runnable_load = 0; - unsigned long min_avg_load = ULONG_MAX, this_avg_load = 0; + unsigned long min_runnable_load = ULONG_MAX; + unsigned long this_runnable_load = ULONG_MAX; + unsigned long min_avg_load = ULONG_MAX, this_avg_load = ULONG_MAX; unsigned long most_spare = 0, this_spare = 0; int load_idx = sd->forkexec_idx; int imbalance_scale = 100 + (sd->imbalance_pct-100)/2; -- 2.14.1