From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751402AbdJEMfN (ORCPT ); Thu, 5 Oct 2017 08:35:13 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:51987 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbdJEMfM (ORCPT ); Thu, 5 Oct 2017 08:35:12 -0400 Date: Thu, 5 Oct 2017 15:34:59 +0300 From: Dan Carpenter To: Srishti Sharma Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Staging: rtl8188eu: core: rtw_mlme_ext: Use list_for_each_entry_safe Message-ID: <20171005123459.3m53oolhizgpug5o@mwanda> References: <1507137416-3855-1-git-send-email-srishtishar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507137416-3855-1-git-send-email-srishtishar@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 04, 2017 at 10:46:56PM +0530, Srishti Sharma wrote: > drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > index 52f31c7..4e1d06c 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > @@ -5446,6 +5446,7 @@ u8 mlme_evt_hdl(struct adapter *padapter, unsigned char *pbuf) > > u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf) > { > + struct xmit_frame *tmp; > if (send_beacon(padapter) == _FAIL) { You need a blank line between the declaration and the code. regards, dan carpenter