From: Mark Greer <mgreer@animalcreek.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
Vaibhav Agarwal <vaibhav.sr@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 2/3] greybus: audio: don't inclide rwlock.h directly.
Date: Thu, 5 Oct 2017 08:17:28 -0700 [thread overview]
Message-ID: <20171005151728.GA10198@animalcreek.com> (raw)
In-Reply-To: <20171005125655.12373-2-bigeasy@linutronix.de>
On Thu, Oct 05, 2017 at 02:56:54PM +0200, Sebastian Andrzej Siewior wrote:
> rwlock.h should not be included directly. Instead linux/splinlock.h
> should be included. One thing it does is to break the RT build.
>
> Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>
> Cc: Mark Greer <mgreer@animalcreek.com>
> Cc: Johan Hovold <johan@kernel.org>
> Cc: Alex Elder <elder@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: greybus-dev@lists.linaro.org
> Cc: devel@driverdev.osuosl.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> drivers/staging/greybus/audio_manager.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
> index aa6508b44fab..045696ce85c7 100644
> --- a/drivers/staging/greybus/audio_manager.c
> +++ b/drivers/staging/greybus/audio_manager.c
> @@ -10,7 +10,7 @@
> #include <linux/sysfs.h>
> #include <linux/module.h>
> #include <linux/init.h>
> -#include <linux/rwlock.h>
> +#include <linux/spinlock.h>
> #include <linux/idr.h>
>
> #include "audio_manager.h"
> --
> 2.14.2
Thanks for the patch.
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
next prev parent reply other threads:[~2017-10-05 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 12:56 [PATCH 1/3] arm/xen: " Sebastian Andrzej Siewior
2017-10-05 12:56 ` [PATCH 2/3] greybus: audio: " Sebastian Andrzej Siewior
2017-10-05 15:17 ` Mark Greer [this message]
2017-10-05 12:56 ` [PATCH 3/3] xen/9pfs: " Sebastian Andrzej Siewior
2017-10-05 19:58 ` [PATCH 1/3] arm/xen: don't inclide rwlock.h directly.1~B Stefano Stabellini
2017-10-05 21:32 ` Sebastian Andrzej Siewior
2017-10-26 22:56 ` [Xen-devel] " Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005151728.GA10198@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=bigeasy@linutronix.de \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®