From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752132AbdJEUCO (ORCPT ); Thu, 5 Oct 2017 16:02:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:49409 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751405AbdJEUCN (ORCPT ); Thu, 5 Oct 2017 16:02:13 -0400 Date: Thu, 5 Oct 2017 22:02:10 +0200 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= To: SF Markus Elfring Cc: linuxppc-dev@lists.ozlabs.org, Arnd Bergmann , Benjamin Herrenschmidt , Jeremy Kerr , Michael Ellerman , Paul Mackerras , kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH 1/2] powerpc/platforms/cell: Delete an error message for a failed memory allocation in three functions Message-ID: <20171005220210.681f78e8@kitsune.suse.cz> In-Reply-To: <62146108-5be0-c236-f404-4be122e162ac@users.sourceforge.net> References: <62146108-5be0-c236-f404-4be122e162ac@users.sourceforge.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, 5 Oct 2017 21:36:26 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 5 Oct 2017 21:04:30 +0200 > > Omit extra messages for a memory allocation failure in these > functions. this is bogus. All these functions return -1 on any error. Until they reflect the error in their return value (and it is properly propagated to the user) there is no way to tell WTF failed without the message. > > This issue was detected by using the Coccinelle software. > ... which provides only a hint which should be evaluated by the user. Thanks Michal