From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751906AbdJEWJb (ORCPT ); Thu, 5 Oct 2017 18:09:31 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:47365 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369AbdJEWJ3 (ORCPT ); Thu, 5 Oct 2017 18:09:29 -0400 X-Google-Smtp-Source: AOwi7QDPUahKbsVHGeHRlwyw1j1WAAJqRFcgA0ij/YHvnGmGEJhVF0hCkigHa8le0iWUjpO5uNyVPw== Date: Thu, 5 Oct 2017 17:09:27 -0500 From: Rob Herring To: Florian Fainelli Cc: Andrew Lunn , Corentin Labbe , mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, frowand.list@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v6 11/11] of: mdio: Prevent of_mdiobus_register from scanning mdio-mux nodes Message-ID: <20171005220927.7rabn3ftvow253xj@rob-hp-laptop> References: <20170927073414.17361-1-clabbe.montjoie@gmail.com> <20170927073414.17361-12-clabbe.montjoie@gmail.com> <20170927141213.GF13516@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 27, 2017 at 09:50:46PM -0700, Florian Fainelli wrote: > > > On 09/27/2017 07:12 AM, Andrew Lunn wrote: > > On Wed, Sep 27, 2017 at 09:34:14AM +0200, Corentin Labbe wrote: > >> Each child node of an MDIO node is scanned as a PHY when calling > >> of_mdiobus_register() givint the following result: > >> [ 18.175379] mdio_bus stmmac-0: /soc/ethernet@1c30000/mdio/mdio-mux has invalid PHY address > >> [ 18.175408] mdio_bus stmmac-0: scan phy mdio-mux at address 0 > >> [ 18.175450] mdio_bus stmmac-0: scan phy mdio-mux at address 1 > >> [...] > >> [ 18.176420] mdio_bus stmmac-0: scan phy mdio-mux at address 30 > >> [ 18.176452] mdio_bus stmmac-0: scan phy mdio-mux at address 31 > >> > >> Since mdio-mux nodes are not PHY, this patch a way to to not scan > >> them. > > > > Hi Corentin > > > > I still don't like this, but ... > > Me neither, even more so as I don't understand the reasoning behind > putting the mux as a child node of the MDIO bus controller in the first > place. If no one agrees with me, then you shouldn't just accept my answers. I'm not always right. Looking at this some more, why can't mdio-mux-mmio be used? Then there is nothing to review or discuss. If you want to extend that then make it clear this is just extending/inheriting already defined bindings. That being said, if we were starting over I would probably do mux designs differently with DT hierarchy reflecting the mux hierarchy, but that ship has sailed. Rob