mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Jia-Ju Bai <baijiaju1990@163.com>
Cc: viro@zeniv.linux.org.uk, torbjorn.lindh@gopta.se,
	rgooch@atnf.csiro.au, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [BUG] fs/super: a possible sleep-in-atomic bug in put_super
Date: Fri, 6 Oct 2017 11:06:04 +0200	[thread overview]
Message-ID: <20171006090604.m5oxcyb2xtllpmpu@dhcp22.suse.cz> (raw)
In-Reply-To: <06badf5e-292d-ef63-7499-6888dec1b9b0@163.com>

[CC Vladimir]

On Fri 06-10-17 16:59:18, Jia-Ju Bai wrote:
> According to fs/super.c, the kernel may sleep under a spinlock.
> The function call path is:
> put_super (acquire the spinlock)
>   __put_super
>     destroy_super
>       list_lru_destroy
>         list_lru_unregister
>           mutex_lock --> may sleep
>         memcg_get_cache_ids
>           down_read --> may sleep
> 
> This bug is found by my static analysis tool and my code review.
> 
> Thanks,
> Jia-Ju Bai

-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2017-10-06  9:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06  8:59 Jia-Ju Bai
2017-10-06  9:06 ` Michal Hocko [this message]
2017-10-07 11:56   ` Vladimir Davydov
2017-10-07 17:06     ` Al Viro
2017-10-07 21:14       ` Al Viro
2017-10-08  0:56         ` Al Viro
2017-10-08  2:03           ` Al Viro
2017-10-08 15:47             ` Vladimir Davydov
2017-10-08 21:13               ` Al Viro
2017-10-09  8:43                 ` Vladimir Davydov
2017-10-06 12:19 ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171006090604.m5oxcyb2xtllpmpu@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=baijiaju1990@163.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rgooch@atnf.csiro.au \
    --cc=torbjorn.lindh@gopta.se \
    --cc=vdavydov.dev@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®