From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752034AbdJFN4A (ORCPT ); Fri, 6 Oct 2017 09:56:00 -0400 Received: from foss.arm.com ([217.140.101.70]:34332 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751846AbdJFNz6 (ORCPT ); Fri, 6 Oct 2017 09:55:58 -0400 Date: Fri, 6 Oct 2017 14:55:55 +0100 From: Catalin Marinas To: Konstantin Khlebnikov Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kmemleak: change /sys/kernel/debug/kmemleak permissions from 0444 to 0644 Message-ID: <20171006135554.eiwezlqq6gyhy6wa@armageddon.cambridge.arm.com> References: <150728996582.744328.11541332857988399411.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <150728996582.744328.11541332857988399411.stgit@buzz> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 06, 2017 at 02:39:25PM +0300, Konstantin Khlebnikov wrote: > Kmemleak could be tweaked in runtime by writing commands into debugfs file. > Root anyway can use it, but without write-bit this interface isn't obvious. > > Signed-off-by: Konstantin Khlebnikov > --- > mm/kmemleak.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index 7780cd83a495..fca3452e56c1 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -2104,7 +2104,7 @@ static int __init kmemleak_late_init(void) > return -ENOMEM; > } > > - dentry = debugfs_create_file("kmemleak", S_IRUGO, NULL, NULL, > + dentry = debugfs_create_file("kmemleak", 0644, NULL, NULL, > &kmemleak_fops); > if (!dentry) > pr_warn("Failed to create the debugfs kmemleak file\n"); Acked-by: Catalin Marinas -- Catalin