From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753168AbdJGCBE (ORCPT ); Fri, 6 Oct 2017 22:01:04 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:52000 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752685AbdJGCBD (ORCPT ); Fri, 6 Oct 2017 22:01:03 -0400 Date: Sat, 07 Oct 2017 03:01:03 +0100 (WEST) Message-Id: <20171007.030103.394881238635414484.davem@davemloft.net> To: michael.chan@broadcom.com Cc: jtoppins@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef From: David Miller In-Reply-To: References: <1a4d96f368f199bba0425012f50d55d634484cce.1507319311.git.jtoppins@redhat.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 06 Oct 2017 19:01:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michael Chan Date: Fri, 6 Oct 2017 18:27:31 -0700 > On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins wrote: >> There is no reason to wrap the data structures inside the ifdef. > > What's so bad about wrapping unused data structures inside #ifdef? > These structures are only used if CONFIG_BNXT_FLOWER_OFFLOAD is > defined. Yeah I agree, this ifdef is actually a good way to trap unintentional usage of those datastructures so it's doubly best to keep the ifdef.