From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753557AbdJHRAS (ORCPT <rfc822;w@1wt.eu>);
        Sun, 8 Oct 2017 13:00:18 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:58874 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751626AbdJHRAQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 8 Oct 2017 13:00:16 -0400
Date: Sun, 08 Oct 2017 10:00:13 -0700 (PDT)
Message-Id: <20171008.100013.2081721941420989813.davem@davemloft.net>
To: yamada.masahiro@socionext.com
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
        akpm@linux-foundation.org, abbotti@mev.co.uk, mingo@kernel.org,
        torvalds@linux-foundation.org, linux-rdma@vger.kernel.org,
        yishaih@mellanox.com, tariqt@mellanox.com, netdev@vger.kernel.org
Subject: Re: [PATCH 10/12] net/mlx4: replace <linux/radix-tree.h> with
 <linux/radix-tree-root.h>
From: David Miller <davem@davemloft.net>
In-Reply-To: <1507479013-5207-11-git-send-email-yamada.masahiro@socionext.com>
References: <1507479013-5207-1-git-send-email-yamada.masahiro@socionext.com>
        <1507479013-5207-11-git-send-email-yamada.masahiro@socionext.com>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 08 Oct 2017 10:00:15 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Mon,  9 Oct 2017 01:10:11 +0900

> The headers
>  - include/linux/mlx4/device.h
>  - drivers/net/ethernet/mellanox/mlx4/mlx4.h
> require the definition of struct radix_tree_root, but do not need to
> know anything about other radix tree stuff.
> 
> Include <linux/radix-tree-root.h> instead of <linux/radix-tree.h> to
> reduce the header dependency.
> 
> While we are here, let's add missing <linux/radix-tree.h> where
> radix tree accessors are used.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Honestly this makes things more complicated.

The driver was trying to consolidate all of the header needs
by including them all in one place, the main driver header.

Now you're including headers in several different files.

I really don't like the results of this change and would
ask you to reconsider.

Just add both radix-tree-root.h _and_ radix-tree.h to mlx4.h
and leave the rest of the driver alone.