From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751824AbdJIET3 (ORCPT ); Mon, 9 Oct 2017 00:19:29 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:38930 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbdJIET2 (ORCPT ); Mon, 9 Oct 2017 00:19:28 -0400 Date: Sun, 08 Oct 2017 21:19:27 -0700 (PDT) Message-Id: <20171008.211927.1175489723468947303.davem@davemloft.net> To: chris.gekas@gmail.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: stmmac: Clean up dead code From: David Miller In-Reply-To: <1507490029-26406-1-git-send-email-chris.gekas@gmail.com> References: <1507490029-26406-1-git-send-email-chris.gekas@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 08 Oct 2017 21:19:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christos Gkekas Date: Sun, 8 Oct 2017 20:13:49 +0100 > Many macros in dwmac-ipq806x are unused and should be removed. > Moreover gmac->id is an unsigned variable and therefore checking > whether it is less than zero is redundant. > > Signed-off-by: Christos Gkekas Applied.