From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514AbdJHSmS (ORCPT ); Sun, 8 Oct 2017 14:42:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:49738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753236AbdJHSmR (ORCPT ); Sun, 8 Oct 2017 14:42:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 382BA21925 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Sun, 8 Oct 2017 14:42:14 -0400 From: Steven Rostedt To: Joel Fernandes Cc: Linux Kernel Mailing List , Ingo Molnar , Andrew Morton , Jessica Yu , "Joel Fernandes (Google)" Subject: Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps Message-ID: <20171008144214.5c45774c@gandalf.local.home> In-Reply-To: References: <20171006180655.935479946@goodmis.org> <20171006180730.737778041@goodmis.org> <20171007093221.0799f929@gandalf.local.home> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 8 Oct 2017 01:42:15 -0700 Joel Fernandes wrote: > Hi Steve, > > > "Joel Fernandes (Google)" wrote: > [..] > > Also could you let me know what is the correct behavior of the filters > > after a module being traced is unloaded, are the filters supposed to > > be setup again after the module is unloaded, before the module can be > > loaded again? > > Actually I learnt that it doesn't get preserved and wrote a patch to fix that, let me know > what you think, thanks. (its only lightly tested - checked that the filters are preserved, > will do more testing tomorrow): They should not be preserved, it's too non-deterministic. I'm wondering why the setting of the ip to zero didn't keep it from showing up again. I'll have to investigate that. -- Steve