From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755220AbdJIRbA (ORCPT ); Mon, 9 Oct 2017 13:31:00 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:52656 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754655AbdJIRa6 (ORCPT ); Mon, 9 Oct 2017 13:30:58 -0400 Date: Mon, 09 Oct 2017 10:30:57 -0700 (PDT) Message-Id: <20171009.103057.2069299695410118368.davem@davemloft.net> To: mika.westerberg@linux.intel.com Cc: andreas.noever@gmail.com, michael.jamet@intel.com, yehezkel.bernat@intel.com, fengguang.wu@intel.com, gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thunderbolt: Initialize Thunderbolt bus earlier From: David Miller In-Reply-To: <20171009132234.65540-1-mika.westerberg@linux.intel.com> References: <20171009132234.65540-1-mika.westerberg@linux.intel.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 09 Oct 2017 10:30:58 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mika Westerberg Date: Mon, 9 Oct 2017 16:22:34 +0300 > The 0day kbuild robot reports following crash: ... > The reason is that both Thunderbolt bus and thunderbolt-net are build > into the kernel image, and the latter is linked first because > drivers/net comes before drivers/thunderbolt. Since both use > module_init() thunderbolt-net ends up calling Thunderbolt bus functions > too early triggering the above crash. > > Fix this by moving Thunderbolt bus initialization to happen earlier to > make sure all the data structures are ready when Thunderbolt service > drivers are initialized. To be on the safe side also add a check for > properly initialized xdomain_property_dir to tb_register_property_dir(). > > Reported-by: kernel test robot > Signed-off-by: Mika Westerberg Applied to net-next, thanks.