mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	kbuild test robot <fengguang.wu@intel.com>,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bitfield: Use __ffs64(x) to fix missing __ffsdi2()
Date: Mon, 9 Oct 2017 07:34:34 -0700	[thread overview]
Message-ID: <20171009073434.0110d4fb@cakuba.netronome.com> (raw)
In-Reply-To: <1507538449-22775-1-git-send-email-geert+renesas@glider.be>

On Mon,  9 Oct 2017 10:40:49 +0200, Geert Uytterhoeven wrote:
> On most architectures[*], gcc turns __builtin_ffsll() into a call to
> __ffsdi2(), which is not provided by any architecture, leading to
> failures like:
> 
>     rcar-gen3-cpg.c:(.text+0x289): undefined reference to `__ffsdi2'
> 
> To fix this, use __ffs64() instead, which is available on all
> architectures.
> 
> [*] Known exceptions are some 64-bit architectures like amd64, arm64,
>     ia64, powerpc64, and tilegx.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Fixes: 3e9b3112ec74f192 ("add basic register-field manipulation macros")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>

Thanks!

  reply	other threads:[~2017-10-09 14:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-09  8:40 Geert Uytterhoeven
2017-10-09 14:34 ` Jakub Kicinski [this message]
2017-10-09 22:37 ` kbuild test robot
2017-10-09 22:53 ` Jakub Kicinski
2017-10-10  7:03   ` Geert Uytterhoeven
2017-10-10 15:06     ` Jakub Kicinski
2017-10-09 22:57 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171009073434.0110d4fb@cakuba.netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=fengguang.wu@intel.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®