From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751733AbdJIJAC (ORCPT ); Mon, 9 Oct 2017 05:00:02 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:56963 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbdJIJAB (ORCPT ); Mon, 9 Oct 2017 05:00:01 -0400 X-Google-Smtp-Source: AOwi7QBl6QDv4vOBbESyI9ToWl5s8hXUetbgBnsnk+WAkhnoNNcYlvuHK2JjKvHRjnY3paRMfvUAbg== Date: Mon, 9 Oct 2017 10:59:57 +0200 From: Daniel Vetter To: Chris Wilson Cc: Harsha Sharma , daniel.vetter@ffwll.ch, seanpaul@chromium.org, jani.nikula@linux.intel.com, outreachy-kernel@googlegroups.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH v3] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put() Message-ID: <20171009085957.nwfree4igdhiqtuf@phenom.ffwll.local> Mail-Followup-To: Chris Wilson , Harsha Sharma , seanpaul@chromium.org, jani.nikula@linux.intel.com, outreachy-kernel@googlegroups.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20171008140407.13927-1-harshasharmaiitr@gmail.com> <150747381515.24532.16488907175098177864@mail.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <150747381515.24532.16488907175098177864@mail.alporthouse.com> X-Operating-System: Linux phenom 4.12.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 08, 2017 at 03:43:35PM +0100, Chris Wilson wrote: > Quoting Harsha Sharma (2017-10-08 15:04:07) > > @@ -624,7 +624,7 @@ static bool intel_fbdev_init_bios(struct drm_device *dev, > > ifbdev->preferred_bpp = fb->base.format->cpp[0] * 8; > > ifbdev->fb = fb; > > > > - drm_framebuffer_reference(&ifbdev->fb->base); > > + drm_framebuffer_put(&ifbdev->fb->base); > > Whoops. Hm yeah, how did this happen? Does cocci really do this, or is that an accident from manually fixing stuff up? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch